GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AMD fam10 binaryPI: Remove invalid PCI ops on CPU domain 

Device is of type CPU_CLUSTER, while pci_dev_set_resources()
expects PCI_DOMAIN.

Change-Id: Ib1add47d71071abb6e9c28e3a85dd0b671741b71
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/17697
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Kyösti Mälkki 2016-12-02 16:02:30 +02:00
parent 27198ac2e3
commit 48f82a9beb
6 changed files with 11 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/northbridge/amd/agesa/family10/northbridge.c
View File

@ -1101,18 +1101,9 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_read_resources(device_t dev)
{
}
static void cpu_bus_set_resources(device_t dev)
{
pci_dev_set_resources(dev);
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,

20
src/northbridge/amd/agesa/family12/northbridge.c
View File

@ -652,22 +652,6 @@ static void domain_enable_resources(device_t dev)
/* Bus related code */ /* Bus related code */
static void cpu_bus_read_resources(device_t dev)
{
printk(BIOS_DEBUG, "\nFam12h - northbridge.c - %s - Start.\n",__func__);
printk(BIOS_DEBUG, "Fam12h - northbridge.c - %s - End.\n",__func__);
}
static void cpu_bus_set_resources(device_t dev)
{
printk(BIOS_DEBUG, "\nFam12h - northbridge.c - %s - Start.\n",__func__);
pci_dev_set_resources(dev);
printk(BIOS_DEBUG, "Fam12h - northbridge.c - %s - End.\n",__func__);
}
static void cpu_bus_init(device_t dev) static void cpu_bus_init(device_t dev)
{ {
printk(BIOS_DEBUG, "\nFam12h - northbridge.c - %s - Start.\n",__func__); printk(BIOS_DEBUG, "\nFam12h - northbridge.c - %s - Start.\n",__func__);
@ -813,8 +797,8 @@ static struct device_operations pci_domain_ops = {
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = 0, .scan_bus = 0,

7
src/northbridge/amd/amdfam10/northbridge.c
View File

@ -1955,14 +1955,9 @@ static void cpu_bus_init(device_t dev)
#endif #endif
} }
static void cpu_bus_set_resources(struct device *dev)
{
pci_dev_set_resources(dev);
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = DEVICE_NOOP, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,

13
src/northbridge/amd/pi/00660F01/northbridge.c
View File

@ -1088,18 +1088,9 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_read_resources(device_t dev)
{
}
static void cpu_bus_set_resources(device_t dev)
{
pci_dev_set_resources(dev);
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,

13
src/northbridge/amd/pi/00670F00/northbridge.c
View File

@ -1089,18 +1089,9 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_read_resources(device_t dev)
{
}
static void cpu_bus_set_resources(device_t dev)
{
pci_dev_set_resources(dev);
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,

13
src/northbridge/amd/pi/00730F01/northbridge.c
View File

@ -1108,18 +1108,9 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_read_resources(device_t dev)
{
}
static void cpu_bus_set_resources(device_t dev)
{
pci_dev_set_resources(dev);
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_set_resources, .set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,