GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/amd/agesa/hudson: Const'ify pci_devfn_t devices 

Change-Id: I5a9078baa2224865d0746b6d41f6053ac3a51e09
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40603
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Elyes HAOUAS 2020-04-22 16:14:26 +02:00 committed by Michał Żygowski
parent fcfca1da5e
commit 49f63e0aa1
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/southbridge/amd/agesa/hudson/bootblock.c
View File

@ -19,9 +19,7 @@
static void hudson_enable_rom(void) static void hudson_enable_rom(void)
{ {
u8 reg8; u8 reg8;
pci_devfn_t dev; const pci_devfn_t dev = PCI_DEV(0, 0x14, 3);
dev = PCI_DEV(0, 0x14, 3);
/* Decode variable LPC ROM address ranges 1 and 2. */ /* Decode variable LPC ROM address ranges 1 and 2. */
reg8 = pci_s_read_config8(dev, 0x48); reg8 = pci_s_read_config8(dev, 0x48);
@ -49,7 +47,6 @@ static void hudson_enable_rom(void)
void bootblock_early_southbridge_init(void) void bootblock_early_southbridge_init(void)
{ {
pci_devfn_t dev;
u32 data; u32 data;
hudson_enable_rom(); hudson_enable_rom();
@ -61,7 +58,7 @@ void bootblock_early_southbridge_init(void)
else if (CONFIG(POST_DEVICE_LPC)) else if (CONFIG(POST_DEVICE_LPC))
hudson_lpc_port80(); hudson_lpc_port80();
dev = PCI_DEV(0, 0x14, 3); const pci_devfn_t dev = PCI_DEV(0, 0x14, 3);
data = pci_read_config32(dev, LPC_IO_OR_MEM_DECODE_ENABLE); data = pci_read_config32(dev, LPC_IO_OR_MEM_DECODE_ENABLE);
/* enable 0x2e/0x4e IO decoding for SuperIO */ /* enable 0x2e/0x4e IO decoding for SuperIO */
pci_write_config32(dev, LPC_IO_OR_MEM_DECODE_ENABLE, data | 3); pci_write_config32(dev, LPC_IO_OR_MEM_DECODE_ENABLE, data | 3);

6
src/southbridge/amd/agesa/hudson/early_setup.c
View File

@ -60,10 +60,9 @@ void hudson_pci_port80(void)
void hudson_lpc_port80(void) void hudson_lpc_port80(void)
{ {
u8 byte; u8 byte;
pci_devfn_t dev;
/* Enable port 80 LPC decode in pci function 3 configuration space. */ /* Enable port 80 LPC decode in pci function 3 configuration space. */
dev = PCI_DEV(0, 0x14, 3); const pci_devfn_t dev = PCI_DEV(0, 0x14, 3);
byte = pci_read_config8(dev, 0x4a); byte = pci_read_config8(dev, 0x4a);
byte |= 1 << 5; /* enable port 80 */ byte |= 1 << 5; /* enable port 80 */
pci_write_config8(dev, 0x4a, byte); pci_write_config8(dev, 0x4a, byte);
@ -71,13 +70,12 @@ void hudson_lpc_port80(void)
void hudson_lpc_decode(void) void hudson_lpc_decode(void)
{ {
pci_devfn_t dev;
u32 tmp; u32 tmp;
/* Enable LPC controller */ /* Enable LPC controller */
pm_write8(0xec, pm_read8(0xec) | 0x01); pm_write8(0xec, pm_read8(0xec) | 0x01);
dev = PCI_DEV(0, 0x14, 3); const pci_devfn_t dev = PCI_DEV(0, 0x14, 3);
/* Serial port enumeration on Hudson: /* Serial port enumeration on Hudson:
* PORT0 - 0x3f8 * PORT0 - 0x3f8
* PORT1 - 0x2f8 * PORT1 - 0x2f8