intel/fsp_rangeley: change non-existent config options to #defines
Kconfig symbols CONFIG_ACPI_INCLUDE_PMIO and CONFIG_ACPI_INCLUDE_GPIO were never added to the coreboot codebase when the Rangeley code was brought in from Sage. These symbols disabled ACPI code that was unused because it caused dmesg warnings due to conflicts with drivers trying to claim the same addresses as the ACPI code. Because it could be used on some other platforms, it was left in instead of being completely removed. - Change the Kconfig symbol names to simple #defines in the mainboard code. - Add the #defines along with comments to the reference platform. - Hook everything together in dsdt.asl - Update new mainboard littleplains the same way. Change-Id: I1f62157c6e447ea9b7207699572930e4711fc3e0 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/12552 Reviewed-by: David Guckian <david.guckian@intel.com> Tested-by: build bot (Jenkins)
This commit is contained in:
parent
7c38e1e8bc
commit
49fdf3f957
5 changed files with 14 additions and 2 deletions
|
@ -14,6 +14,9 @@
|
|||
* GNU General Public License for more details.
|
||||
*/
|
||||
|
||||
// #define ACPI_INCLUDE_PMIO 1 /* uncomment to enable PMIO block in soc.asl */
|
||||
// #define ACPI_INCLUDE_GPIO 1 /* uncomment to enable GPIO block in soc.asl */
|
||||
|
||||
Device (PWRB)
|
||||
{
|
||||
Name(_HID, EisaId("PNP0C0C"))
|
||||
|
|
|
@ -23,6 +23,9 @@ DefinitionBlock(
|
|||
0x20110725 // OEM revision
|
||||
)
|
||||
{
|
||||
// Include mainboard configuration
|
||||
#include <acpi/mainboard.asl>
|
||||
|
||||
// Include debug methods
|
||||
#include <arch/x86/acpi/debug.asl>
|
||||
|
||||
|
|
|
@ -14,6 +14,9 @@
|
|||
* GNU General Public License for more details.
|
||||
*/
|
||||
|
||||
// #define ACPI_INCLUDE_PMIO 1 /* uncomment to enable PMIO block in soc.asl */
|
||||
// #define ACPI_INCLUDE_GPIO 1 /* uncomment to enable GPIO block in soc.asl */
|
||||
|
||||
Device (PWRB)
|
||||
{
|
||||
Name(_HID, EisaId("PNP0C0C"))
|
||||
|
|
|
@ -23,6 +23,9 @@ DefinitionBlock(
|
|||
0x20110725 // OEM revision
|
||||
)
|
||||
{
|
||||
// Include mainboard configuration
|
||||
#include <acpi/mainboard.asl>
|
||||
|
||||
// Include debug methods
|
||||
#include <arch/x86/acpi/debug.asl>
|
||||
|
||||
|
|
|
@ -30,7 +30,7 @@ Scope(\)
|
|||
TRP0, 8 // IO-Trap at 0x808
|
||||
}
|
||||
|
||||
#if IS_ENABLED(CONFIG_ACPI_INCLUDE_PMIO)
|
||||
#ifdef ACPI_INCLUDE_PMIO
|
||||
// PCH Power Management Registers, located at PMBASE (0x1f.0 0x40.l)
|
||||
OperationRegion(PMIO, SystemIO, DEFAULT_ABASE, 0x80)
|
||||
Field(PMIO, ByteAcc, NoLock, Preserve)
|
||||
|
@ -77,7 +77,7 @@ Scope(\)
|
|||
}
|
||||
#endif
|
||||
|
||||
#if IS_ENABLED(CONFIG_ACPI_INCLUDE_GPIO)
|
||||
#ifdef ACPI_INCLUDE_GPIO
|
||||
// GPIO IO mapped registers (0x1f.0 reg 0x48.l)
|
||||
OperationRegion(GPIO, SystemIO, DEFAULT_GPIOBASE, 0x6c)
|
||||
Field(GPIO, ByteAcc, NoLock, Preserve)
|
||||
|
|
Loading…
Reference in a new issue