GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/hatch: Give first NIC in Puff idx 1 for vpd 

The format for VPD has changed s.t. the first NIC should
always have a zero concat to the end. drivers/net supports
this with the workaround of setting the idx to 1.

The longer term fix is to adjust all the respective boards
to shift back by one and adjust drivers/net friends to
remove the 'special casing' of idx == 0.

Background:
https://chromeos.google.com/partner/dlm/docs/factory/vpd.html#field-ethernet_macn

BUG=b:152157720
BRANCH=none
TEST=none

Change-Id: I510428c555b92398a5199b346dffb85d38495d74
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39768
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Edward O'Callaghan 2020-03-23 11:01:08 +11:00 committed by Edward O'Callaghan
parent c632bda2f6
commit 4bd6927388
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/hatch/variants/puff/overridetree.cb
View File

@ -283,6 +283,7 @@ chip soc/intel/cannonlake
register "stop_delay_ms" = "12" # NIC needs time to quiesce register "stop_delay_ms" = "12" # NIC needs time to quiesce
register "stop_off_delay_ms" = "1" register "stop_off_delay_ms" = "1"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "device_index" = "1"
device pci 00.0 on end device pci 00.0 on end
end end
end # FSP requires func0 be enabled. end # FSP requires func0 be enabled.