GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vendorcode/amd/pi/00670F00/Lib/AmdLib.c: Remove IdsErrorStop 

Function IdsErrorStop() is only used within AmdLib.c function
LibAmdMsrRead(), which in turn is only used once within PspBaseLib.c and
three times inside AmdLib.c, all with well defined MSR addresses.
IdsErrorStop() is used as a trap if MSR address is 0 or 0xFFFFFFFF, which
clearly it's not. Therefore it can be safely removed from AmdLib.c.

BUG=b:112885948
TEST=Build grunt

Change-Id: I47ffcbd4fbae28b6d711a340f0ac3f3b007e8e4f
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/28295
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Richard Spiegel 2018-08-23 13:46:34 -07:00 committed by Martin Roth
parent 837e3387e5
commit 4c7349cf85
1 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/vendorcode/amd/pi/00670F00/Lib/amdlib.c
View File

@ -266,9 +266,6 @@ LibAmdMsrRead (
IN OUT AMD_CONFIG_PARAMS *ConfigPtr
)
{
if ((MsrAddress == 0xFFFFFFFF) || (MsrAddress == 0x00000000)) {
IdsErrorStop(MsrAddress);
}
*Value = __readmsr (MsrAddress);
}
@ -574,27 +571,3 @@ GetPciMmioAddress (
}
return MmioIsEnabled;
}
BOOLEAN
IdsErrorStop (
IN UINT32 FileCode
)
{
struct POST {
UINT16 deadlo;
UINT32 messagelo;
UINT16 deadhi;
UINT32 messagehi;
} post = {0xDEAD, FileCode, 0xDEAD, FileCode};
UINT16 offset = 0;
UINT16 j;
while(1) {
offset %= sizeof(struct POST) / 2;
WriteIo16(80, *((UINT16 *)&post)+offset);
++offset;
for (j=0; j<250; ++j) {
ReadIo8(80);
}
}
}