GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/gma/Kconfig: Avoid dependency hell when ignoring straps 

Unconditionally selecting `GFX_GMA_IGNORE_PRESENCE_STRAPS` creates a
hard dependency on `MAINBOARD_USE_LIBGFXINIT`, which is undesired. Move
it out of the `if GFX_GMA` block to break this unwanted dependency.

TEST=Build for Librem 13v4 with no graphics init successfully.

Change-Id: I53e132c209c065068f20959fa1a6f5195f5fe766
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43491
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Angel Pons 2020-07-16 00:56:27 +02:00
parent b21bffae0c
commit 51e138c25b
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/drivers/intel/gma/Kconfig
View File

@ -68,6 +68,14 @@ config GFX_GMA_ANALOG_I2C_HDMI_C
config GFX_GMA_ANALOG_I2C_HDMI_D config GFX_GMA_ANALOG_I2C_HDMI_D
bool bool
config GFX_GMA_IGNORE_PRESENCE_STRAPS
def_bool n
depends on MAINBOARD_HAS_LIBGFXINIT
help
libgfxinit uses the GPU presence straps to determine if a display port
is present/enabled. Select this option if a board doesn't correctly implement
these straps, causing libgfxinit to fail to detect an attached panel.
config GFX_GMA config GFX_GMA
def_bool y def_bool y
depends on NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X \ depends on NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X \
@ -127,11 +135,4 @@ config GFX_GMA_ANALOG_I2C_PORT
digital displays. In that case, the EDID for a VGA display has to be digital displays. In that case, the EDID for a VGA display has to be
read over the I2C interface of the coupled digital port. read over the I2C interface of the coupled digital port.
config GFX_GMA_IGNORE_PRESENCE_STRAPS
def_bool n
help
libgfxinit uses the GPU presence straps to determine if a display port
is present/enabled. Select this option if a board doesn't correctly implement
these straps, causing libgfxinit to fail to detect an attached panel.
endif endif