nb/intel: Replace bad uses of `find_resource`
The `find_resource` function will never return null (will die instead). In cases where the existing code already accounts for null pointers, it is better to use `probe_resource` instead, which returns a null pointer instead of dying. Change-Id: I617fea8a09049e9a87130640835ea6c3e2faec60 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58906 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
This commit is contained in:
parent
f32ae10f0d
commit
536d36a748
|
@ -151,7 +151,7 @@ static void gma_func0_init(struct device *dev)
|
|||
|
||||
intel_gma_init_igd_opregion();
|
||||
|
||||
gtt_res = find_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
gtt_res = probe_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
if (gtt_res == NULL)
|
||||
return;
|
||||
mmio = res2mmio(gtt_res, 0, 0);
|
||||
|
|
|
@ -178,7 +178,7 @@ static void gma_pm_init_pre_vbios(struct device *dev)
|
|||
{
|
||||
printk(BIOS_DEBUG, "GT Power Management Init\n");
|
||||
|
||||
gtt_res = find_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
gtt_res = probe_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
if (!gtt_res || !gtt_res->base)
|
||||
return;
|
||||
|
||||
|
|
|
@ -51,7 +51,7 @@ static void minihd_init(struct device *dev)
|
|||
int codec_mask, i;
|
||||
|
||||
/* Find base address */
|
||||
res = find_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
res = probe_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
if (!res)
|
||||
return;
|
||||
|
||||
|
|
|
@ -140,7 +140,7 @@ static void gma_func0_init(struct device *dev)
|
|||
if (!CONFIG(NO_GFX_INIT))
|
||||
pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER);
|
||||
|
||||
gtt_res = find_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
gtt_res = probe_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
if (!gtt_res || !gtt_res->base)
|
||||
return;
|
||||
|
||||
|
@ -171,7 +171,7 @@ static void gma_read_resources(struct device *dev)
|
|||
struct resource *res;
|
||||
|
||||
/* Set the graphics memory to write combining. */
|
||||
res = find_resource(dev, PCI_BASE_ADDRESS_2);
|
||||
res = probe_resource(dev, PCI_BASE_ADDRESS_2);
|
||||
if (res == NULL) {
|
||||
printk(BIOS_DEBUG, "gma: memory resource not found.\n");
|
||||
return;
|
||||
|
|
|
@ -308,7 +308,7 @@ static void gma_pm_init_pre_vbios(struct device *dev)
|
|||
|
||||
printk(BIOS_DEBUG, "GT Power Management Init\n");
|
||||
|
||||
gtt_res = find_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
gtt_res = probe_resource(dev, PCI_BASE_ADDRESS_0);
|
||||
if (!gtt_res || !gtt_res->base)
|
||||
return;
|
||||
|
||||
|
|
Loading…
Reference in New Issue