GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86: remove printk() from init_timer() 

For console drivers which use udelay() we can deadlock
in the printk path on the spinlock. The reason is that
on the first call to udelay() from within a console driver
it will go back down the printk() path deadlocking oneself.

Just remove the printk() as it was asymmetric on romstage
vs ramstage.

Change-Id: I30fe7d6e5b4684f17d4f353c0816b64f9242de0a
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/10483
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Aaron Durbin 2015-06-09 15:02:50 -05:00
parent 4f2f01a8fa
commit 5793b7371d
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cpu/x86/tsc/delay_tsc.c
View File

@ -152,10 +152,8 @@ static unsigned long long calibrate_tsc(void)
void init_timer(void) void init_timer(void)
{ {
if (!clocks_per_usec) { if (!clocks_per_usec)
clocks_per_usec = calibrate_tsc(); clocks_per_usec = calibrate_tsc();
printk(BIOS_INFO, "clocks_per_usec: %lu\n", clocks_per_usec);
}
} }
static inline unsigned long get_clocks_per_usec(void) static inline unsigned long get_clocks_per_usec(void)