GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload: gdb: Condition video console init on LP_VIDEO_CONSOLE 

With the stub video_console_init() removed from depthcharge in
CL:2241493, depthcharge will fail to compile:

 payloads/libpayload/gdb/stub.c:76: undefined reference to
 `video_console_init'

Since video_console_init() is meant to be implemented in
libpayload, libpayload should be consistent with itself by not calling
this function when it's not implemented (i.e., when !LP_VIDEO_CONSOLE).

Therefore, initialize video console only if LP_VIDEO_CONSOLE is set.

BRANCH=none
BUG=none
TEST=USE="menu_ui" emerge-gale depthcharge

Change-Id: Ic45f9073330258cb77301003484ec525b2404180
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42505
Reviewed-by: Joel Kitching <kitching@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Yu-Ping Wu 2020-06-18 15:55:30 +08:00 committed by Patrick Georgi
parent 2c807ff6fe
commit 59495543db
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
payloads/libpayload/gdb/stub.c
View File

@ -73,6 +73,7 @@ static void gdb_output_write(const void *buffer, size_t count)
if (!gdb_state.resumed) { if (!gdb_state.resumed) {
/* Must be a die_if() in GDB (or a bug), so bail out and die. */ /* Must be a die_if() in GDB (or a bug), so bail out and die. */
gdb_exit(-1); gdb_exit(-1);
if (CONFIG(LP_VIDEO_CONSOLE))
video_console_init(); video_console_init();
puts("GDB died, redirecting its last words to the screen:\n"); puts("GDB died, redirecting its last words to the screen:\n");
console_write(buffer, count); console_write(buffer, count);