GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

inteltool: Fix message in case of multiple LPC controllers 

If we find multiple LPC controllers, we want to tell the user that we'll
ignore all but the first. However, we use 'dev' in the message (the
current device found) instead of 'sb' (the one we want to use).

Fix the message by using 'sb' and break the loop right away in this
case. It's sufficient to tell the user once which LPC controller we'll
use.

Change-Id: Ibd27e40525fabe8c63b112691ad49fd994c70a48
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Reviewed-on: http://review.coreboot.org/7342
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins)
This commit is contained in:
Mathias Krause 2014-11-05 21:27:01 +01:00
parent 0cc8f29316
commit 5ad6ec55f8
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
util/inteltool/inteltool.c
View File

@ -339,13 +339,14 @@ int main(int argc, char *argv[])
pci_fill_info(dev, PCI_FILL_CLASS); pci_fill_info(dev, PCI_FILL_CLASS);
/* The ISA/LPC bridge can be 0x1f, 0x07, or 0x04 so we probe. */ /* The ISA/LPC bridge can be 0x1f, 0x07, or 0x04 so we probe. */
if (dev->device_class == 0x0601) { /* ISA/LPC bridge */ if (dev->device_class == 0x0601) { /* ISA/LPC bridge */
if (sb == NULL) if (sb == NULL) {
sb = dev; sb = dev;
else } else {
fprintf(stderr, "Multiple devices with class ID" fprintf(stderr, "Multiple devices with class ID"
" 0x0601, using %02x%02x:%02x.%02x\n", " 0x0601, using %02x%02x:%02x.%02x\n",
dev->domain, dev->bus, dev->dev, sb->domain, sb->bus, sb->dev, sb->func);
dev->func); break;
}
} }
} }