GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/common/smbus_ops.c: Clean up read resources 

Using `pci_dev_read_resources` works just as well on bd82x6x (the
allocator does the same) and allows dropping the i82801gx check.

Change-Id: I1cb05131a82ebb7c45827eff8e09e445d9c695b3
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48538
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2020-12-10 17:29:25 +01:00 committed by Nico Huber
parent 3ee6d7bf22
commit 5f73432737
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/southbridge/intel/common/smbus_ops.c
View File

@ -67,17 +67,12 @@ struct smbus_bus_operations lops_smbus_bus = {
void smbus_read_resources(struct device *dev) void smbus_read_resources(struct device *dev)
{ {
pci_dev_read_resources(dev);
struct resource *res = new_resource(dev, PCI_BASE_ADDRESS_4); struct resource *res = new_resource(dev, PCI_BASE_ADDRESS_4);
res->base = CONFIG_FIXED_SMBUS_IO_BASE; res->base = CONFIG_FIXED_SMBUS_IO_BASE;
res->size = 32; res->size = 32;
res->limit = res->base + res->size - 1; res->limit = res->base + res->size - 1;
res->flags = IORESOURCE_IO | IORESOURCE_FIXED | IORESOURCE_RESERVE | res->flags = IORESOURCE_IO | IORESOURCE_FIXED | IORESOURCE_RESERVE |
IORESOURCE_STORED | IORESOURCE_ASSIGNED; IORESOURCE_STORED | IORESOURCE_ASSIGNED;
/* The memory BAR does not exist for ICH7 and earlier */
if (CONFIG(SOUTHBRIDGE_INTEL_I82801GX))
return;
/* Also add MMIO resource */
res = pci_get_resource(dev, PCI_BASE_ADDRESS_0);
} }