GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/quanta/it8518: correct ACPI battery data fed into ToString() 

ToString() requires the input buffer data to be null-terminated,
but the data returned by the EC is not, leading Windows to fail
to report any battery data at all.  Correct this by concatenating
a null terminator (0x00) to the end of the buffer data before
inputting to ToString() where needed

TEST: boot Windows on google/stout, observe battery data
reported correctly.

Change-Id: I974afcd6ff1c617301d0897d6bd1fe14200aa3b9
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/21579
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Matt DeVillier 2017-09-17 14:24:31 -05:00 committed by Martin Roth
parent f11d0c3414
commit 6781648054
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ec/quanta/it8518/acpi/battery.asl
View File

@ -185,7 +185,7 @@ Device (BATX)
//
// Battery Type - Device Chemistry
//
Store (ToString (SBCH), Index (PBIF, 11))
Store (ToString (Concatenate(SBCH, 0x00)), Index (PBIF, 11))
//
// Information ID 5 -
@ -196,7 +196,7 @@ Device (BATX)
//
// OEM Information - Manufacturer Name
//
Store (ToString (SBMN), Index (PBIF, 12))
Store (ToString (Concatenate(SBMN, 0x00)), Index (PBIF, 12))
//
// Information ID 6 -
@ -207,7 +207,7 @@ Device (BATX)
//
// Model Number - Device Name
//
Store (ToString (SBDN), Index (PBIF, 9))
Store (ToString (Concatenate(SBDN, 0x00)), Index (PBIF, 9))
Return (PBIF)
}