GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

southbridge/amd/cimx/sb800: Uninitialized variables in config func 

Both 'SbSpiSpeedSupport' and 'UsbRxMode' are uninitiated upon return from
a 'sb800_cimx_config()' call.

Change-Id: I32237ff97fafc3e69627d427e54268dcb039e12c
Found-by: Coverity Scan
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6474
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Edward O'Callaghan 2014-08-03 19:42:02 +10:00
parent aaaf689007
commit 691ff08e27
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/southbridge/amd/cimx/sb800/cfg.c
View File

@ -122,10 +122,13 @@ void sb800_cimx_config(AMDSBCFG *sb_config)
sb_config->SpreadSpectrum = SPREAD_SPECTRUM; sb_config->SpreadSpectrum = SPREAD_SPECTRUM;
sb_config->PciClks = PCI_CLOCK_CTRL; sb_config->PciClks = PCI_CLOCK_CTRL;
sb_config->HpetTimer = HPET_TIMER; sb_config->HpetTimer = HPET_TIMER;
sb_config->SbSpiSpeedSupport = 1;
/* USB */ /* USB */
sb_config->USBMODE.UsbModeReg = USB_CONFIG; sb_config->USBMODE.UsbModeReg = USB_CONFIG;
sb_config->SbUsbPll = 0; sb_config->SbUsbPll = 0;
/* CG PLL multiplier for USB Rx 1.1 mode (0=disable, 1=enable) */
sb_config->UsbRxMode = 1;
/* SATA */ /* SATA */
sb_config->SataClass = SATA_MODE; sb_config->SataClass = SATA_MODE;