GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpi/acpigen.c: Remove unused and incorrect functions 

acpigen_write_name_zero() and acpigen_write_name_one() are not
implemented correctly, and are not used anywhere. Drop them in
favor of the more flexible acpigen_write_name_integer() function.

Signed-off-by: Jakub Czapiga <jacz@semihalf.com>
Change-Id: I116fd41624a8e8b536d18d747f21d3131b734dfc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49834
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Lance Zhao
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Jakub Czapiga 2021-01-22 15:47:11 +01:00 committed by Angel Pons
parent ade4f3520b
commit 7435e254d4
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/acpi/acpigen.c
View File

@ -151,18 +151,6 @@ void acpigen_write_integer(uint64_t data)
acpigen_write_qword(data); acpigen_write_qword(data);
} }
void acpigen_write_name_zero(const char *name)
{
acpigen_write_name(name);
acpigen_write_one();
}
void acpigen_write_name_one(const char *name)
{
acpigen_write_name(name);
acpigen_write_zero();
}
void acpigen_write_name_byte(const char *name, uint8_t val) void acpigen_write_name_byte(const char *name, uint8_t val)
{ {
acpigen_write_name(name); acpigen_write_name(name);

2
src/include/acpi/acpigen.h
View File

@ -312,8 +312,6 @@ void acpigen_write_integer(uint64_t data);
void acpigen_write_string(const char *string); void acpigen_write_string(const char *string);
void acpigen_write_name_unicode(const char *name, const char *string); void acpigen_write_name_unicode(const char *name, const char *string);
void acpigen_write_name(const char *name); void acpigen_write_name(const char *name);
void acpigen_write_name_zero(const char *name);
void acpigen_write_name_one(const char *name);
void acpigen_write_name_string(const char *name, const char *string); void acpigen_write_name_string(const char *name, const char *string);
void acpigen_write_name_dword(const char *name, uint32_t val); void acpigen_write_name_dword(const char *name, uint32_t val);
void acpigen_write_name_qword(const char *name, uint64_t val); void acpigen_write_name_qword(const char *name, uint64_t val);