GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/agah: Remove variant_finalize 

The EEs and I misunderstood, and apparently the vfio-pci kernel driver
will turn off the dGPU when it sees it is unused, so coreboot should
leave the dGPU on so the kernel driver can save state before it shuts it
down.

TEST=Tested by ODM

Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: I30b5dead7a5302f3385ddcaecfbf134c3bb68779
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65181
Reviewed-by: Robert Zieba <robertzieba@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Tim Wawrzynczak 2022-06-16 13:35:40 -06:00 committed by Martin L Roth
parent 6e28808612
commit 74ed2a5d60
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/mainboard/google/brya/variants/agah/variant.c
View File

@ -138,23 +138,6 @@ void variant_init(void)
dgpu_power_sequence_on(); dgpu_power_sequence_on();
} }
void variant_finalize(void)
{
if (acpi_is_wakeup_s3() || !gpu_powered_on)
return;
/*
* Because the dGPU is used here in a way similar to "hybrid graphics"
* modes, it is powered down here. The DRIVERS_GFX_NVIDIA_SAVE_BARS
* option is selected for agah, so the BARs will be saved to ACPI memory
* during its finalize routine. Thus, it is powered down here, as the
* proper resources have already been allocated.
*/
dgpu_power_sequence_off();
printk(BIOS_INFO, "GPU power sequenced off.\n");
}
/* Save PCI BARs to the ACPI copy of the "saved PCI config space" */ /* Save PCI BARs to the ACPI copy of the "saved PCI config space" */
void variant_fill_ssdt(const struct device *unused) void variant_fill_ssdt(const struct device *unused)
{ {