GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/stoneyridge: Use uint8_t as type for SPD address 

SPD address is currenty int. It should be uint8_t.

BUG=b:62200225

Change-Id: Ia11c5994c41849ba01ecae3cee6fa97c527134d0
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/22300
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Richard Spiegel 2017-11-10 08:33:57 -07:00 committed by Aaron Durbin
parent cd04e31c8b
commit 77fee09509
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/dimmSpd.h
View File

@ -20,7 +20,7 @@ AGESA_STATUS
AmdMemoryReadSPD(IN UINT32 Func, IN UINTN Data, AmdMemoryReadSPD(IN UINT32 Func, IN UINTN Data,
IN OUT AGESA_READ_SPD_PARAMS *SpdData); IN OUT AGESA_READ_SPD_PARAMS *SpdData);
int sb_readSpd(int spdAddress, char *buf, size_t len); int sb_readSpd(uint8_t spdAddress, char *buf, size_t len);
int smbus_readSpd(int spdAddress, char *buf, size_t len); int smbus_readSpd(int spdAddress, char *buf, size_t len);
#endif #endif

2
src/soc/amd/stoneyridge/dimmSpd.c
View File

@ -27,7 +27,7 @@
AGESA_STATUS AmdMemoryReadSPD(UINT32 unused1, UINTN unused2, AGESA_STATUS AmdMemoryReadSPD(UINT32 unused1, UINTN unused2,
AGESA_READ_SPD_PARAMS *info) AGESA_READ_SPD_PARAMS *info)
{ {
int spdAddress; uint8_t spdAddress;
DEVTREE_CONST struct device *dev = dev_find_slot(0, DCT_DEVFN); DEVTREE_CONST struct device *dev = dev_find_slot(0, DCT_DEVFN);
DEVTREE_CONST struct soc_amd_stoneyridge_config *conf = dev->chip_info; DEVTREE_CONST struct soc_amd_stoneyridge_config *conf = dev->chip_info;

6
src/soc/amd/stoneyridge/smbus_spd.c
View File

@ -30,10 +30,10 @@
* sending offset for every byte. * sending offset for every byte.
* Reads 128 bytes in 7-8 ms at 400 KHz. * Reads 128 bytes in 7-8 ms at 400 KHz.
*/ */
static int readspd(uint16_t iobase, int SmbusSlaveAddress, static int readspd(uint16_t iobase, uint8_t SmbusSlaveAddress,
char *buffer, size_t count) char *buffer, size_t count)
{ {
u8 dev_addr; uint8_t dev_addr;
size_t index; size_t index;
int error; int error;
char *pbuf = buffer; char *pbuf = buffer;
@ -90,7 +90,7 @@ static void setupFch(uint16_t ioBase)
outb(SMBSLV_STAT_CLEAR, ioBase + SMBSLVSTAT); outb(SMBSLV_STAT_CLEAR, ioBase + SMBSLVSTAT);
} }
int sb_readSpd(int spdAddress, char *buf, size_t len) int sb_readSpd(uint8_t spdAddress, char *buf, size_t len)
{ {
uint16_t ioBase = SMB_BASE_ADDR; uint16_t ioBase = SMB_BASE_ADDR;
setupFch(ioBase); setupFch(ioBase);