GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload/i8042/keyboard: Log errors during initialization 

Add error messages for all failed commands in keyboard_init().

Change-Id: Ie42ccbc4d850912c83e00376b27f192d5b652057
Signed-off-by: Furquan Shaikh <furquan@google.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33446
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2019-06-03 19:02:31 -07:00
parent 3bf4e28fb8
commit 7c369c1e45
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
payloads/libpayload/drivers/i8042/keyboard.c
View File

@ -319,25 +319,33 @@ void keyboard_init(void)
/* Set scancode set 1 */ /* Set scancode set 1 */
ret = keyboard_cmd(I8042_KBCMD_SET_SCANCODE); ret = keyboard_cmd(I8042_KBCMD_SET_SCANCODE);
if (!ret && !CONFIG(LP_PC_KEYBOARD_IGNORE_INIT_FAILURE)) if (!ret && !CONFIG(LP_PC_KEYBOARD_IGNORE_INIT_FAILURE)) {
printf("ERROR: Keyboard set scancode failed!\n");
return; return;
}
ret = keyboard_cmd(I8042_SCANCODE_SET_1); ret = keyboard_cmd(I8042_SCANCODE_SET_1);
if (!ret && !CONFIG(LP_PC_KEYBOARD_IGNORE_INIT_FAILURE)) if (!ret && !CONFIG(LP_PC_KEYBOARD_IGNORE_INIT_FAILURE)) {
printf("ERROR: Keyboard scancode set#1 failed!\n");
return; return;
}
/* /*
* Set default parameters. * Set default parameters.
* Fix for broken QEMU ps/2 make scancodes. * Fix for broken QEMU ps/2 make scancodes.
*/ */
ret = keyboard_cmd(0xf6); ret = keyboard_cmd(0xf6);
if (!ret) if (!ret) {
printf("ERROR: Keyboard set default params failed!\n");
return; return;
}
/* Enable scanning */ /* Enable scanning */
ret = keyboard_cmd(I8042_KBCMD_EN); ret = keyboard_cmd(I8042_KBCMD_EN);
if (!ret && !CONFIG(LP_PC_KEYBOARD_IGNORE_INIT_FAILURE)) if (!ret && !CONFIG(LP_PC_KEYBOARD_IGNORE_INIT_FAILURE)) {
printf("ERROR: Keyboard enable scanning failed!\n");
return; return;
}
console_add_input_driver(&cons); console_add_input_driver(&cons);
} }