GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/guybrush: Re-arrange override speed config 

Currently override speed config is applied only for non EM100 cases.
For EM100 case, override speed board version defaults to 0 leading to
"comparison of unsigned expression >= 0 is always true" error. Fix this
error by defining the override speed config for both EM100 and non-EM100
use-cases.

BUG=None
TEST=Build Guybrush for both EM100 and non-EM100 cases.

Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Change-Id: Id8ee7b01c69c4555d6e6a7b0d5f095ea3aaf3405
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58309
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Karthikeyan Ramasubramanian 2021-10-13 14:36:13 -06:00 committed by Raul Rangel
parent 2353cd9936
commit 7c6d673c26
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/guybrush/Kconfig
View File

@ -111,6 +111,8 @@ config NORMAL_READ_SPI_SPEED
config ALT_SPI_SPEED config ALT_SPI_SPEED
default 0 # 66MHz default 0 # 66MHz
endif # !EM100
config OVERRIDE_EFS_SPI_SPEED config OVERRIDE_EFS_SPI_SPEED
int int
default 3 if EM100 default 3 if EM100
@ -127,8 +129,6 @@ config OVERRIDE_EFS_SPI_SPEED_MIN_BOARD
Minimum board version starting which the Override EFS SPI Speed Minimum board version starting which the Override EFS SPI Speed
configuration has to be applied. configuration has to be applied.
endif # !EM100
config VARIANT_DIR config VARIANT_DIR
default "guybrush" if BOARD_GOOGLE_GUYBRUSH default "guybrush" if BOARD_GOOGLE_GUYBRUSH
default "nipperkin" if BOARD_GOOGLE_NIPPERKIN default "nipperkin" if BOARD_GOOGLE_NIPPERKIN