GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device: Clarify use of `config_of()` 

We don't want unnecessary die() calls to spread throughout coreboot.
Chances are high that we'd add a NON_FATAL_DIE Kconfig eventually.

Change-Id: I01c7efdf23672bad3a195b7dc1565a3cc8a087bd
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46046
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber 2020-10-05 11:08:44 +02:00
parent b5e4e34418
commit 7e6ee912c6
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/include/device/device.h
View File

@ -339,6 +339,12 @@ DEVTREE_CONST struct device *pcidev_path_on_root_debug(pci_devfn_t devfn, const
void devtree_bug(const char *func, pci_devfn_t devfn);
void __noreturn devtree_die(void);
/*
* Dies if `dev` or `dev->chip_info` are NULL. Returns `dev->chip_info` otherwise.
*
* Only use if missing `chip_info` is fatal and we can't boot. If it's
* not fatal, please handle the NULL case gracefully.
*/
static inline DEVTREE_CONST void *config_of(const struct device *dev)
{
if (dev && dev->chip_info)