GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc/amd/fsp/picasso: Rename the fsp_ddi and fsp_pcie descriptors 

This change was missed when I ported over fsp_params.c.

BUG=b:157140753
TEST=Boot trembyle to OS

Fixes: 89e51e6178 ("soc/amd/picasso: Allow mainboard to provide pci ddi descriptors")
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Icdb6aebe5a3be7174170bdf37a1f379f02dcc5a5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41579
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Raul E Rangel 2020-05-20 13:52:32 -06:00 committed by Felix Held
parent b768723c72
commit 7ed04e460d
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/vendorcode/amd/fsp/picasso/platform_descriptors.h
View File

@ -101,17 +101,15 @@ typedef enum {
MAX_CONNECTOR_TYPE // Not valid value, used to verify input MAX_CONNECTOR_TYPE // Not valid value, used to verify input
} pcie_connector_type; } pcie_connector_type;
/* DDI Descriptor: used for configuring display outputs */ /* Picasso DDI Descriptor: used for configuring display outputs */
typedef struct __packed { typedef struct __packed {
uint8_t connector_type; uint8_t connector_type;
uint8_t aux_index; uint8_t aux_index;
uint8_t hdp_index; uint8_t hdp_index;
uint8_t reserved; uint8_t reserved;
} fsp_ddi_descriptor; } picasso_fsp_ddi_descriptor;
/* PCIe Descriptor: used for assigning lanes, bifurcation and other settings */ /* Picasso PCIe Descriptor: used for assigning lanes, bifurcation and other settings */
/* Since the code will always be compiled as little endian, using a bitfield struct should be
safe here. */
typedef struct __packed { typedef struct __packed {
uint8_t engine_type; uint8_t engine_type;
uint8_t start_lane; // Start lane of the pci device uint8_t start_lane; // Start lane of the pci device
@ -139,6 +137,6 @@ typedef struct __packed {
unsigned int channel_type :3; unsigned int channel_type :3;
unsigned int turn_off_unused_lanes :1; unsigned int turn_off_unused_lanes :1;
uint8_t reserved[4]; uint8_t reserved[4];
} fsp_pcie_descriptor; } picasso_fsp_pcie_descriptor;
#endif /* __PI_PICASSO_PLATFORM_DESCRIPTORS_H__ */ #endif /* __PI_PICASSO_PLATFORM_DESCRIPTORS_H__ */