GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AGESA f14: Remove early HT init 

Syncronise HT init code with f12 vendorcode.

Constructor for HT init is not required since init itself
is not called.

Change-Id: I0552c4d019c700f84d98473978afb18fe4eea1e8
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/26040
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Kyösti Mälkki 2017-08-31 22:02:56 +03:00
parent 807e4232f7
commit 7f937cb172
3 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/vendorcode/amd/agesa/f14/Config/OptionHtInstall.h
View File

@ -273,7 +273,9 @@
#if (OPTION_FAMILY12H == TRUE) || (OPTION_FAMILY14H == TRUE) #if (OPTION_FAMILY12H == TRUE) || (OPTION_FAMILY14H == TRUE)
#undef OPTION_HT_INIIT_RESET_ENTRY #undef OPTION_HT_INIIT_RESET_ENTRY
#undef OPTION_HT_INIIT_RESET_CONSTRUCTOR_ENTRY
#define OPTION_HT_INIIT_RESET_ENTRY NULL #define OPTION_HT_INIIT_RESET_ENTRY NULL
#define OPTION_HT_INIIT_RESET_CONSTRUCTOR_ENTRY NULL
#endif #endif
#if ((OPTION_FAMILY10H == TRUE) || (OPTION_FAMILY15H == TRUE)) #if ((OPTION_FAMILY10H == TRUE) || (OPTION_FAMILY15H == TRUE))
@ -292,7 +294,8 @@
}; };
CONST OPTION_HT_INIT_RESET ROMDATA HtOptionInitReset = { CONST OPTION_HT_INIT_RESET ROMDATA HtOptionInitReset = {
OPTION_HT_INIIT_RESET_ENTRY OPTION_HT_INIIT_RESET_ENTRY,
OPTION_HT_INIIT_RESET_CONSTRUCTOR_ENTRY
}; };
#endif #endif

11
src/vendorcode/amd/agesa/f14/Include/OptionsHt.h
View File

@ -88,11 +88,20 @@ F_OPTION_HT_INIT_RESET (
typedef F_OPTION_HT_INIT_RESET *PF_OPTION_HT_INIT_RESET; typedef F_OPTION_HT_INIT_RESET *PF_OPTION_HT_INIT_RESET;
typedef AGESA_STATUS
F_OPTION_HT_RESET_CONSTRUCTOR (
IN AMD_CONFIG_PARAMS *StdHeader,
IN AMD_HT_RESET_INTERFACE *AmdHtResetInterface
);
typedef F_OPTION_HT_RESET_CONSTRUCTOR *PF_OPTION_HT_RESET_CONSTRUCTOR;
/** /**
* Provide HT reset initialization build option results * Provide HT reset initialization build option results
*/ */
typedef struct { typedef struct {
PF_OPTION_HT_INIT_RESET HtInitReset; ///< Method: HT reset initialization. PF_OPTION_HT_INIT_RESET HtInitReset; ///< Method: HT reset initialization.
PF_OPTION_HT_RESET_CONSTRUCTOR HtResetConstructor; ///< Method: HT reset initialization.
} OPTION_HT_INIT_RESET; } OPTION_HT_INIT_RESET;
/*---------------------------------------------------------------------------------------- /*----------------------------------------------------------------------------------------

5
src/vendorcode/amd/agesa/f14/Proc/Common/AmdInitReset.c
View File

@ -249,7 +249,10 @@ AmdInitResetConstructor (
AmdResetParams->StdHeader = *StdHeader; AmdResetParams->StdHeader = *StdHeader;
AmdInitResetExecutionCacheAllocateInitializer (&AmdResetParams->StdHeader, &AmdResetParams->CacheRegion[0]); AmdInitResetExecutionCacheAllocateInitializer (&AmdResetParams->StdHeader, &AmdResetParams->CacheRegion[0]);
AmdHtResetConstructor (&AmdResetParams->StdHeader, &AmdResetParams->HtConfig); // Initialize Hyper Transport input structure
if (HtOptionInitReset.HtResetConstructor != NULL) {
HtOptionInitReset.HtResetConstructor (&AmdResetParams->StdHeader, &AmdResetParams->HtConfig);
}
return AGESA_SUCCESS; return AGESA_SUCCESS;
} }