GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/asus/p2b: Remove variant validation guards from DSDT 

With conversion to variant structure complete, remove temporary guards
inserted to help validate the move.

With this change, all P2B family boards (currently p2b and p2b-ls)
share the same S-state declarations.

TEST=No apparent ACPI regression observed on p2b-ls.

Change-Id: Ibd6e49adeae2a42800ee5bfd74b3850eb19843a5
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41051
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Keith Hui 2020-04-19 16:03:24 -04:00 committed by Angel Pons
parent 99dbca381b
commit 81f9ae9ff1
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/mainboard/asus/p2b/dsdt.asl
View File

@ -19,13 +19,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1)
P80, 8
}
/*
* For now only define 2 power states:
* - S0 which is fully on
* - S5 which is soft off
* Any others would involve declaring the wake up methods.
*/
/*
* Intel 82371EB (PIIX4E) datasheet, section 7.2.3, page 142
*
@ -43,15 +36,9 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1)
* 6: reserved
* 7: reserved
*/
/* Guard these entries for the purpose of variant validation. They will be aligned later. */
Name (\_S0, Package () { 0x05, 0x05, 0x00, 0x00 })
#if CONFIG(BOARD_ASUS_P2B)
Name (\_S1, Package () { 0x03, 0x03, 0x00, 0x00 })
Name (\_S5, Package () { 0x00, 0x00, 0x00, 0x00 })
#endif
#if CONFIG(BOARD_ASUS_P2B_LS)
Name (\_S5, Package () { 0x00, 0x06, 0x00, 0x00 })
#endif
OperationRegion (GPOB, SystemIO, DEFAULT_PMBASE+DEVCTL, 0x10)
Field (GPOB, ByteAcc, NoLock, Preserve)