sb/intel/common: Show "Add EC firmware" only for boards that need it

Most boards currently do not use EC firmware from SPI flash in the
IFD, this hides this option by default and shows it only for boards
that need it.

A new config variable MAINBOARD_USES_IFD_EC_REGION is introduced to
enable this option for boards that need it.

The following list of boards requiring this was provided by
Lijian Zhao:
1. intel/cannonlake_rvp
2. intel/coffeelake_rvp
3. intel/icelake_rvp
4. google/sarien
5. google/hatch

Change-Id: I52ab977319d99a23a5e982cc01479fe801e172a7
Signed-off-by: Jan Tatje <jan@jnt.io>
Reviewed-on: https://review.coreboot.org/c/30697
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
This commit is contained in:
Jan Tatje 2019-01-06 17:38:36 +01:00 committed by Patrick Georgi
parent 7bc4dc5648
commit 82a4e27341
6 changed files with 9 additions and 1 deletions

View file

@ -15,6 +15,7 @@ config BOARD_GOOGLE_BASEBOARD_HATCH
select SOC_INTEL_CANNONLAKE_MEMCFG_INIT select SOC_INTEL_CANNONLAKE_MEMCFG_INIT
select SOC_INTEL_COFFEELAKE select SOC_INTEL_COFFEELAKE
select SYSTEM_TYPE_LAPTOP select SYSTEM_TYPE_LAPTOP
select MAINBOARD_USES_IFD_EC_REGION
if BOARD_GOOGLE_BASEBOARD_HATCH if BOARD_GOOGLE_BASEBOARD_HATCH

View file

@ -22,6 +22,7 @@ config BOARD_GOOGLE_BASEBOARD_SARIEN
select SPD_READ_BY_WORD select SPD_READ_BY_WORD
select SYSTEM_TYPE_LAPTOP select SYSTEM_TYPE_LAPTOP
select TPM2 select TPM2
select MAINBOARD_USES_IFD_EC_REGION
if BOARD_GOOGLE_BASEBOARD_SARIEN if BOARD_GOOGLE_BASEBOARD_SARIEN

View file

@ -11,6 +11,7 @@ config BOARD_SPECIFIC_OPTIONS
select DRIVERS_I2C_HID select DRIVERS_I2C_HID
select DRIVERS_I2C_GENERIC select DRIVERS_I2C_GENERIC
select SOC_INTEL_CANNONLAKE select SOC_INTEL_CANNONLAKE
select MAINBOARD_USES_IFD_EC_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View file

@ -16,6 +16,7 @@ config BOARD_SPECIFIC_OPTIONS
select SOC_INTEL_CANNONLAKE_PCH_H if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 select SOC_INTEL_CANNONLAKE_PCH_H if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_WHISKEYLAKE_RVP select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_WHISKEYLAKE_RVP
select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP select SOC_INTEL_COMMON_BLOCK_HDA if BOARD_INTEL_WHISKEYLAKE_RVP
select MAINBOARD_USES_IFD_EC_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View file

@ -13,6 +13,7 @@ config BOARD_SPECIFIC_OPTIONS
select DRIVERS_USB_ACPI select DRIVERS_USB_ACPI
select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_COMMON_BLOCK_HDA_VERB
select SOC_INTEL_ICELAKE select SOC_INTEL_ICELAKE
select MAINBOARD_USES_IFD_EC_REGION
config MAINBOARD_DIR config MAINBOARD_DIR
string string

View file

@ -120,9 +120,12 @@ config GBE_BIN_PATH
depends on HAVE_GBE_BIN depends on HAVE_GBE_BIN
default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/gbe.bin" default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/gbe.bin"
config MAINBOARD_USES_IFD_EC_REGION
def_bool n
config HAVE_EC_BIN config HAVE_EC_BIN
bool "Add EC firmware" bool "Add EC firmware"
depends on HAVE_IFD_BIN depends on HAVE_IFD_BIN && MAINBOARD_USES_IFD_EC_REGION
help help
The embedded controller needs a firmware file. The embedded controller needs a firmware file.