GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0/hand_off_block: Remove dead decrement 

Value stored to 'size' is never read.
Also drop unused parameter.

Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41697
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Elyes HAOUAS 2020-08-07 15:28:51 +02:00 committed by Patrick Georgi
parent 2a59db7573
commit 83b6283e61
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/drivers/intel/fsp2_0/hand_off_block.c
View File

@ -207,7 +207,7 @@ const void *fsp_find_extension_hob_by_guid(const uint8_t *guid, size_t *size)
return NULL; return NULL;
} }
static void display_fsp_version_info_hob(const void *hob, size_t size) static void display_fsp_version_info_hob(const void *hob)
{ {
#if CONFIG(DISPLAY_FSP_VERSION_INFO) #if CONFIG(DISPLAY_FSP_VERSION_INFO)
const FIRMWARE_VERSION_INFO *fvi; const FIRMWARE_VERSION_INFO *fvi;
@ -219,7 +219,6 @@ static void display_fsp_version_info_hob(const void *hob, size_t size)
fvi = (void *)&fvih[1]; fvi = (void *)&fvih[1];
str_ptr = (char *)((uintptr_t)fvi + str_ptr = (char *)((uintptr_t)fvi +
(fvih->Count * sizeof(FIRMWARE_VERSION_INFO))); (fvih->Count * sizeof(FIRMWARE_VERSION_INFO)));
size -= sizeof(SMBIOS_STRUCTURE);
for (index = 0; index < fvih->Count; index++) { for (index = 0; index < fvih->Count; index++) {
cnt = strlen(str_ptr); cnt = strlen(str_ptr);
@ -279,7 +278,7 @@ void fsp_display_fvi_version_hob(void)
if (fsp_guid_compare(hob_uuid, uuid_fv_info)) { if (fsp_guid_compare(hob_uuid, uuid_fv_info)) {
size = hob->length - (HOB_HEADER_LEN + 16); size = hob->length - (HOB_HEADER_LEN + 16);
display_fsp_version_info_hob(hob, size); display_fsp_version_info_hob(hob);
} }
} }
} }