GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/denverton_ns: Drop redundant `DEFAULT_ACPI_BASE` 

It is only used in one place, and there's two other equivalent macros.

Change-Id: I7c8241e28f688abd2df8180559dd02ee441c7023
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49282
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Angel Pons 2021-01-10 18:02:27 +01:00 committed by Patrick Georgi
parent 6279cabb5b
commit 83bdb45116
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/intel/denverton_ns/include/soc/iomap.h
View File

@ -12,7 +12,6 @@
/* Southbridge internal device IO BARs (Set to match FSP settings) */ /* Southbridge internal device IO BARs (Set to match FSP settings) */
#define DEFAULT_PMBASE 0x1800 #define DEFAULT_PMBASE 0x1800
#define DEFAULT_ACPI_BASE DEFAULT_PMBASE
#define ACPI_BASE_ADDRESS DEFAULT_PMBASE #define ACPI_BASE_ADDRESS DEFAULT_PMBASE
#define DEFAULT_TCO_BASE 0x400 #define DEFAULT_TCO_BASE 0x400

2
src/soc/intel/denverton_ns/pmc.c
View File

@ -16,7 +16,7 @@
/* While we read BAR dynamically in case it changed, let's /* While we read BAR dynamically in case it changed, let's
* initialize it with a same value * initialize it with a same value
*/ */
static u16 acpi_base = DEFAULT_ACPI_BASE; static u16 acpi_base = ACPI_BASE_ADDRESS;
static u32 pwrm_base = DEFAULT_PWRM_BASE; static u32 pwrm_base = DEFAULT_PWRM_BASE;
static void pch_power_options(struct device *dev) { /* TODO */ } static void pch_power_options(struct device *dev) { /* TODO */ }