GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: Avoid NULL pointer deference 

Coverity detects dereference pointers req and res that are NULL when
calling the pmc_send_ipc_cmd function. This change prevents NULL
pointers dereference.

Found-by: Coverity CID 1458068, 1458070, 1458971, 1458073, 1458075,
1458076
TEST=None

Signed-off-by: John Zhao <john.zhao@intel.com>
Change-Id: Ib88fa5f44dd33ad1ad2e763d79438b5c5b78acb4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56124
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
John Zhao 2021-07-06 10:51:16 -07:00 committed by Felix Held
parent 4671983401
commit 8557613617
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/soc/intel/common/block/crashlog/crashlog.c
View File

@ -194,8 +194,8 @@ bool __weak cpu_cl_discovery(void)
int cl_pmc_re_arm_after_reset(void) int cl_pmc_re_arm_after_reset(void)
{ {
const struct pmc_ipc_buffer *req = { 0 }; const struct pmc_ipc_buffer req = { 0 };
struct pmc_ipc_buffer *res = NULL; struct pmc_ipc_buffer res;
uint32_t cmd_reg; uint32_t cmd_reg;
int r; int r;
@ -203,7 +203,7 @@ int cl_pmc_re_arm_after_reset(void)
PMC_IPC_CMD_ID_CRASHLOG_RE_ARM_ON_RESET, PMC_IPC_CMD_ID_CRASHLOG_RE_ARM_ON_RESET,
PMC_IPC_CMD_SIZE_SHIFT); PMC_IPC_CMD_SIZE_SHIFT);
r = pmc_send_ipc_cmd(cmd_reg, req, res); r = pmc_send_ipc_cmd(cmd_reg, &req, &res);
if (r < 0) { if (r < 0) {
printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n", __func__); printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n", __func__);
@ -217,8 +217,8 @@ int cl_pmc_re_arm_after_reset(void)
/* Sends PMC IPC to clear CrashLog from PMC SSRAM area */ /* Sends PMC IPC to clear CrashLog from PMC SSRAM area */
int cl_pmc_clear(void) int cl_pmc_clear(void)
{ {
const struct pmc_ipc_buffer *req = { 0 }; const struct pmc_ipc_buffer req = { 0 };
struct pmc_ipc_buffer *res = NULL; struct pmc_ipc_buffer res;
uint32_t cmd_reg; uint32_t cmd_reg;
int r; int r;
@ -226,7 +226,7 @@ int cl_pmc_clear(void)
PMC_IPC_CMD_ID_CRASHLOG_ERASE, PMC_IPC_CMD_ID_CRASHLOG_ERASE,
PMC_IPC_CMD_SIZE_SHIFT); PMC_IPC_CMD_SIZE_SHIFT);
r = pmc_send_ipc_cmd(cmd_reg, req, res); r = pmc_send_ipc_cmd(cmd_reg, &req, &res);
if (r < 0) { if (r < 0) {
printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n", __func__); printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n", __func__);
@ -244,8 +244,8 @@ int cl_pmc_clear(void)
int cl_pmc_en_gen_on_all_reboot(void) int cl_pmc_en_gen_on_all_reboot(void)
{ {
const struct pmc_ipc_buffer *req = { 0 }; const struct pmc_ipc_buffer req = { 0 };
struct pmc_ipc_buffer *res = NULL; struct pmc_ipc_buffer res;
uint32_t cmd_reg; uint32_t cmd_reg;
int r; int r;
@ -253,7 +253,7 @@ int cl_pmc_en_gen_on_all_reboot(void)
PMC_IPC_CMD_ID_CRASHLOG_ON_RESET, PMC_IPC_CMD_ID_CRASHLOG_ON_RESET,
PMC_IPC_CMD_SIZE_SHIFT); PMC_IPC_CMD_SIZE_SHIFT);
r = pmc_send_ipc_cmd(cmd_reg, req, res); r = pmc_send_ipc_cmd(cmd_reg, &req, &res);
if (r < 0) { if (r < 0) {
printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n", __func__); printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n", __func__);