GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT 

Here, vga_disable stored but we read it only if MAINBOARD_DO_NATIVE_VGA_INIT.

Found-by: scan-build 7.0.1-8
Change-Id: I5c359df71568b56f48eca9615c6265da33d4a073
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34331
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Elyes HAOUAS 2019-07-14 09:16:58 +02:00 committed by Patrick Georgi
parent 2c7d184885
commit 8881d57531
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/northbridge/intel/i945/gma.c
View File

@ -703,9 +703,8 @@ static void gma_func0_init(struct device *dev)
pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER
| PCI_COMMAND_IO | PCI_COMMAND_MEMORY); | PCI_COMMAND_IO | PCI_COMMAND_MEMORY);
int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1;
if (CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT)) { if (CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT)) {
int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1;
if (acpi_is_wakeup_s3()) { if (acpi_is_wakeup_s3()) {
printk(BIOS_INFO, printk(BIOS_INFO,
"Skipping native VGA initialization when resuming from ACPI S3.\n"); "Skipping native VGA initialization when resuming from ACPI S3.\n");