GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim: Update ASPM settings for the NVMe device 

This enables L1.2 for the SSD port.

link_hotplug is unused on Mendocino, so remove it while I'm here, just
as code cleanup.  This has no functional difference.

Enabling L1.2 on other devices currently causes problems. Debug is
ongoing.

BUG=b:265890321
TEST=Build & boot, look at states enabled in lspci. Test device
functionality.

Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I8940856a127c8a4ba45148cbbf07a08b621beb4d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72391
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Martin Roth 2023-01-23 10:27:51 -07:00 committed by Felix Held
parent 8dd962b97d
commit 8e1bb93fb8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/skyrim/port_descriptors.c
View File

@ -16,7 +16,6 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = {
.link_speed_capability = GEN3,
.turn_off_unused_lanes = true,
.link_aspm = ASPM_L1,
.link_hotplug = 3,
.clk_req = CLK_REQ2,
},
{ /* SD */
@ -29,7 +28,6 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = {
.link_speed_capability = GEN3,
.turn_off_unused_lanes = true,
.link_aspm = ASPM_L1,
.link_hotplug = 3,
.gpio_group_id = GPIO_27,
.clk_req = CLK_REQ1,
},
@ -43,7 +41,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = {
.link_speed_capability = GEN3,
.turn_off_unused_lanes = true,
.link_aspm = ASPM_L1,
.link_hotplug = 3,
.link_aspm_L1_2 = true,
.gpio_group_id = GPIO_6,
.clk_req = CLK_REQ0,
},