GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

common/block/fast_spi: Perform SPI offset read after lock down operation 

This patch is to provide an additional read SPI pci offset register
BIOS_CONTROL (BC) - offset 0xDC to ensure that the last write is
successful.

Change-Id: I3b36c1a51ac059227631a04eb62b9a6807ed37b1
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/20615
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Subrata Banik 2017-07-21 10:06:17 +05:30 committed by Aaron Durbin
parent ba3ae3eead
commit 8e39009c57
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/soc/intel/common/block/fast_spi/fast_spi.c
View File

@ -67,7 +67,7 @@ void fast_spi_init(void)
} }
/* /*
* Set FAST_SPIBAR BIOS Control BILD bit. * Set FAST_SPIBAR BIOS Control register based on input bit field.
*/ */
static void fast_spi_set_bios_control_reg(uint8_t bios_cntl_bit) static void fast_spi_set_bios_control_reg(uint8_t bios_cntl_bit)
{ {
@ -80,12 +80,22 @@ static void fast_spi_set_bios_control_reg(uint8_t bios_cntl_bit)
pci_write_config8(dev, SPIBAR_BIOS_CONTROL, bc_cntl); pci_write_config8(dev, SPIBAR_BIOS_CONTROL, bc_cntl);
} }
/*
* Ensure an additional read back after performing lock down
*/
static void fast_spi_read_post_write(uint8_t reg)
{
pci_read_config8(PCH_DEV_SPI, reg);
}
/* /*
* Set FAST_SPIBAR BIOS Control BILD bit. * Set FAST_SPIBAR BIOS Control BILD bit.
*/ */
void fast_spi_set_bios_interface_lock_down(void) void fast_spi_set_bios_interface_lock_down(void)
{ {
fast_spi_set_bios_control_reg(SPIBAR_BIOS_CONTROL_BILD); fast_spi_set_bios_control_reg(SPIBAR_BIOS_CONTROL_BILD);
fast_spi_read_post_write(SPIBAR_BIOS_CONTROL);
} }
/* /*
@ -94,6 +104,9 @@ void fast_spi_set_bios_interface_lock_down(void)
void fast_spi_set_lock_enable(void) void fast_spi_set_lock_enable(void)
{ {
fast_spi_set_bios_control_reg(SPIBAR_BIOS_CONTROL_LOCK_ENABLE); fast_spi_set_bios_control_reg(SPIBAR_BIOS_CONTROL_LOCK_ENABLE);
fast_spi_read_post_write(SPIBAR_BIOS_CONTROL);
} }
/* /*
@ -102,6 +115,8 @@ void fast_spi_set_lock_enable(void)
void fast_spi_set_eiss(void) void fast_spi_set_eiss(void)
{ {
fast_spi_set_bios_control_reg(SPIBAR_BIOS_CONTROL_EISS); fast_spi_set_bios_control_reg(SPIBAR_BIOS_CONTROL_EISS);
fast_spi_read_post_write(SPIBAR_BIOS_CONTROL);
} }
/* /*