GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/acpi: Make _CRS methods Serialized, eliminating IASL remarks 

When compiling for the ASUS P8H61-M LX, IASL 20180531 emits the
following remark: "Control Method should be made Serialized (due to
creation of named objects within)". Making the appropriate methods
Serialized eliminates these remarks.

Change-Id: I8e95d9a00a629a2f904c79b78fac20810327ed37
Signed-off-by: Tristan Corrick <tristan@corrick.kiwi>
Reviewed-on: https://review.coreboot.org/27796
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Tristan Corrick 2018-08-01 03:08:53 +12:00 committed by Felix Held
parent 19961a4b1b
commit 8f731b847e
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/superio/acpi/pnp_generic.asl
View File

@ -95,7 +95,7 @@ Device (SUPERIO_ID(PN, SUPERIO_PNP_LDN)) {
} }
#endif #endif
Method (_CRS) Method (_CRS, 0, Serialized)
{ {
Name (CRS, ResourceTemplate () { Name (CRS, ResourceTemplate () {
#ifdef SUPERIO_PNP_IO0 #ifdef SUPERIO_PNP_IO0

6
src/superio/acpi/pnp_kbc.asl
View File

@ -73,7 +73,7 @@ Device (SUPERIO_ID(KBD, SUPERIO_KBC_LDN)) {
PNP_DEFAULT_PSC PNP_DEFAULT_PSC
} }
Method (_CRS) Method (_CRS, 0, Serialized)
{ {
Name (CRS, ResourceTemplate () { Name (CRS, ResourceTemplate () {
IO (Decode16, 0x0000, 0x0000, 0x01, 0x01, IO0) IO (Decode16, 0x0000, 0x0000, 0x01, 0x01, IO0)
@ -133,7 +133,7 @@ Device (SUPERIO_ID(PS2, SUPERIO_KBC_LDN)) {
Return (^^SUPERIO_ID(KBD, SUPERIO_KBC_LDN)._PSC ()) Return (^^SUPERIO_ID(KBD, SUPERIO_KBC_LDN)._PSC ())
} }
Method (_CRS) Method (_CRS, 0, Serialized)
{ {
Name (CRS, ResourceTemplate () { Name (CRS, ResourceTemplate () {
IRQNoFlags (IR1) {} IRQNoFlags (IR1) {}
@ -188,7 +188,7 @@ Device (SUPERIO_ID(PS2, SUPERIO_KBC_PS2LDN)) {
PNP_DEFAULT_PSC PNP_DEFAULT_PSC
} }
Method (_CRS) Method (_CRS, 0, Serialized)
{ {
Name (CRS, ResourceTemplate () { Name (CRS, ResourceTemplate () {
IRQNoFlags (IR1) {} IRQNoFlags (IR1) {}

2
src/superio/acpi/pnp_uart.asl
View File

@ -79,7 +79,7 @@ Device (SUPERIO_ID(SER, SUPERIO_UART_LDN)) {
} }
#endif #endif
Method (_CRS) Method (_CRS, 0, Serialized)
{ {
Name (CRS, ResourceTemplate () { Name (CRS, ResourceTemplate () {
IO (Decode16, 0x0000, 0x0000, 0x08, 0x08, IO0) IO (Decode16, 0x0000, 0x0000, 0x08, 0x08, IO0)