GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/pineview: Refactor `decode_pcie_bar` 

Constify and eliminate local variables where possible to ease reading.

Tested with BUILD_TIMELESS, Foxconn D41S remains identical.

Change-Id: Iaad759886a8f5ac07aabdea8ab1c6d1aa7020dfc
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44140
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Angel Pons 2020-08-03 15:47:30 +02:00
parent 653d8717ba
commit 90de10c17a
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/northbridge/intel/pineview/memmap.c
View File

@ -19,11 +19,7 @@ int decode_pcie_bar(u32 *const base, u32 *const len)
{ {
*base = 0; *base = 0;
*len = 0; *len = 0;
const pci_devfn_t dev = HOST_BRIDGE;
u32 pciexbar = 0;
u32 pciexbar_reg;
u32 reg32;
int max_buses;
const struct { const struct {
u16 num_buses; u16 num_buses;
u32 addr_mask; u32 addr_mask;
@ -34,7 +30,7 @@ int decode_pcie_bar(u32 *const base, u32 *const len)
{0, 0}, {0, 0},
}; };
pciexbar_reg = pci_read_config32(dev, PCIEXBAR); const u32 pciexbar_reg = pci_read_config32(HOST_BRIDGE, PCIEXBAR);
/* MMCFG not supported or not enabled */ /* MMCFG not supported or not enabled */
if (!(pciexbar_reg & (1 << 0))) { if (!(pciexbar_reg & (1 << 0))) {
@ -42,9 +38,9 @@ int decode_pcie_bar(u32 *const base, u32 *const len)
return 0; return 0;
} }
reg32 = (pciexbar_reg >> 1) & 3; const u32 index = (pciexbar_reg >> 1) & 3;
pciexbar = pciexbar_reg & busmask[reg32].addr_mask; const u32 pciexbar = pciexbar_reg & busmask[index].addr_mask;
max_buses = busmask[reg32].num_buses; const int max_buses = busmask[index].num_buses;
if (!pciexbar) { if (!pciexbar) {
printk(BIOS_WARNING, "WARNING: pciexbar invalid\n"); printk(BIOS_WARNING, "WARNING: pciexbar invalid\n");