google/gru: Incorporate feedback to #14279
To avoid diverging too much on an actively developed code base, keep the changes to a separate commit that can be downstreamed more easily: - removed unused includes - gave kevin board a "Kevin" part number - marked RW_LEGACY as CBFS region (to follow up upstream changes) - moved romstage entry point to SoC code (instead of encouraging per-board copy pasta) Change-Id: Ief0c8db3c4af96fe2be2e2397d8874ad06fb6f1f Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-on: https://review.coreboot.org/14362 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
parent
a6dbfb5808
commit
91d94b0907
7 changed files with 3 additions and 11 deletions
|
@ -41,6 +41,7 @@ config MAINBOARD_DIR
|
||||||
|
|
||||||
config MAINBOARD_PART_NUMBER
|
config MAINBOARD_PART_NUMBER
|
||||||
string
|
string
|
||||||
|
default "Kevin" if BOARD_GOOGLE_KEVIN
|
||||||
default "Gru"
|
default "Gru"
|
||||||
|
|
||||||
config MAINBOARD_VENDOR
|
config MAINBOARD_VENDOR
|
||||||
|
|
|
@ -29,7 +29,6 @@ romstage-y += boardid.c
|
||||||
romstage-y += chromeos.c
|
romstage-y += chromeos.c
|
||||||
romstage-y += memlayout.ld
|
romstage-y += memlayout.ld
|
||||||
romstage-y += reset.c
|
romstage-y += reset.c
|
||||||
romstage-y += romstage.c
|
|
||||||
|
|
||||||
ramstage-y += boardid.c
|
ramstage-y += boardid.c
|
||||||
ramstage-y += chromeos.c
|
ramstage-y += chromeos.c
|
||||||
|
|
|
@ -15,10 +15,6 @@
|
||||||
*/
|
*/
|
||||||
|
|
||||||
#include <boot/coreboot_tables.h>
|
#include <boot/coreboot_tables.h>
|
||||||
#include <console/console.h>
|
|
||||||
#include <ec/google/chromeec/ec.h>
|
|
||||||
#include <ec/google/chromeec/ec_commands.h>
|
|
||||||
#include <string.h>
|
|
||||||
#include <vendorcode/google/chromeos/chromeos.h>
|
#include <vendorcode/google/chromeos/chromeos.h>
|
||||||
|
|
||||||
void fill_lb_gpios(struct lb_gpios *gpios)
|
void fill_lb_gpios(struct lb_gpios *gpios)
|
||||||
|
|
|
@ -25,5 +25,5 @@ FLASH@0x0 0x800000 {
|
||||||
SHARED_DATA@0x0 0x10000
|
SHARED_DATA@0x0 0x10000
|
||||||
}
|
}
|
||||||
RW_NVRAM@0x5f0000 0x10000
|
RW_NVRAM@0x5f0000 0x10000
|
||||||
RW_LEGACY@0x600000 0x200000
|
RW_LEGACY(CBFS)@0x600000 0x200000
|
||||||
}
|
}
|
||||||
|
|
|
@ -14,12 +14,7 @@
|
||||||
*
|
*
|
||||||
*/
|
*/
|
||||||
|
|
||||||
#include <arch/cache.h>
|
|
||||||
#include <arch/io.h>
|
|
||||||
#include <boardid.h>
|
|
||||||
#include <boot/coreboot_tables.h>
|
|
||||||
#include <device/device.h>
|
#include <device/device.h>
|
||||||
#include <console/console.h>
|
|
||||||
|
|
||||||
static void mainboard_init(device_t dev)
|
static void mainboard_init(device_t dev)
|
||||||
{
|
{
|
||||||
|
|
|
@ -38,6 +38,7 @@ romstage-y += ../common/spi.c
|
||||||
romstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c
|
romstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c
|
||||||
romstage-y += clock.c
|
romstage-y += clock.c
|
||||||
romstage-y += timer.c
|
romstage-y += timer.c
|
||||||
|
romstage-y += romstage.c
|
||||||
|
|
||||||
################################################################################
|
################################################################################
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue