GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0/hand_off_block: remove unneeded line breaks 

Since the characters per line limit was increased from 80 to 96, some
line breaks can be removed to improve code readability.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I92aa3fec8c8caba143e418efc999ec4a7c5d93c4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69461
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Felix Held 2022-11-08 21:14:34 +01:00
parent dafc6194a0
commit 9405dd066e
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/drivers/intel/fsp2_0/hand_off_block.c
View File

@ -132,8 +132,7 @@ struct hob_resource *find_resource_hob_by_guid(const struct hob_header *hob,
{ {
const struct hob_resource *res; const struct hob_resource *res;
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
hob = fsp_next_hob(hob)) {
if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR)
continue; continue;
@ -195,8 +194,7 @@ const void *fsp_find_extension_hob_by_guid(const uint8_t *guid, size_t *size)
if (!hob) if (!hob)
return NULL; return NULL;
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
hob = fsp_next_hob(hob)) {
if (hob->type != HOB_TYPE_GUID_EXTENSION) if (hob->type != HOB_TYPE_GUID_EXTENSION)
continue; continue;
@ -219,12 +217,10 @@ static void display_fsp_version_info_hob(const void *hob)
uint8_t vs; uint8_t vs;
#if CONFIG(DISPLAY_FSP_VERSION_INFO) #if CONFIG(DISPLAY_FSP_VERSION_INFO)
const FIRMWARE_VERSION_INFO *fvi; const FIRMWARE_VERSION_INFO *fvi;
const FIRMWARE_VERSION_INFO_HOB *fvih = const FIRMWARE_VERSION_INFO_HOB *fvih = (FIRMWARE_VERSION_INFO_HOB *)hob;
(FIRMWARE_VERSION_INFO_HOB *)hob;
fvi = (void *)&fvih[1]; fvi = (void *)&fvih[1];
str_ptr = (char *)((uintptr_t)fvi + str_ptr = (char *)((uintptr_t)fvi + (fvih->Count * sizeof(FIRMWARE_VERSION_INFO)));
(fvih->Count * sizeof(FIRMWARE_VERSION_INFO)));
tcount = fvih->Count; tcount = fvih->Count;
#elif CONFIG(DISPLAY_FSP_VERSION_INFO_2) #elif CONFIG(DISPLAY_FSP_VERSION_INFO_2)
@ -255,8 +251,7 @@ static void display_fsp_version_info_hob(const void *hob)
fvi[index].Version.Revision == 0xFF && fvi[index].Version.Revision == 0xFF &&
fvi[index].Version.BuildNumber == 0xFF && fvi[index].Version.BuildNumber == 0xFF &&
vs == 0) { vs == 0) {
str_ptr = (char *)((uintptr_t)str_ptr + cnt + str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t));
sizeof(uint8_t));
continue; continue;
} }
/* /*
@ -274,13 +269,11 @@ static void display_fsp_version_info_hob(const void *hob)
fvi[index].Version.Revision, fvi[index].Version.Revision,
fvi[index].Version.BuildNumber); fvi[index].Version.BuildNumber);
else { else {
str_ptr = (char *)((uintptr_t)str_ptr + cnt + str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t));
sizeof(uint8_t));
cnt = strlen(str_ptr); cnt = strlen(str_ptr);
printk(BIOS_DEBUG, "%s\n", str_ptr); printk(BIOS_DEBUG, "%s\n", str_ptr);
} }
str_ptr = (char *)((uintptr_t)str_ptr + cnt + str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t));
sizeof(uint8_t));
} }
#endif #endif
} }
@ -294,8 +287,7 @@ void fsp_display_fvi_version_hob(void)
return; return;
printk(BIOS_DEBUG, "Display FSP Version Info HOB\n"); printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
hob = fsp_next_hob(hob)) {
if (hob->type != HOB_TYPE_GUID_EXTENSION) if (hob->type != HOB_TYPE_GUID_EXTENSION)
continue; continue;