GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/via/car: ensure CAR ends up zeroed out 

We need to ensure the cache as ram area is set to all zeroes so that
car_migrated works.

Despite a comment claims the previous value is a test pattern it's
actually not used for any testing. Drop the comment too.

Change-Id: I1c91acbca8a860c2ed9c691d08d18718604682d8
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Reviewed-on: https://review.coreboot.org/25796
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Lubomir Rintel 2018-01-01 14:36:49 +01:00 committed by Patrick Georgi
parent 55fe0827dc
commit 9618cf4362
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cpu/via/car/cache_as_ram.inc
View File

@ -149,12 +149,8 @@ clear_fixed_var_mtrr_out:
movl %esi, %edi movl %esi, %edi
movl $(CacheSize >> 2), %ecx movl $(CacheSize >> 2), %ecx
/* /* Zero out the cache-as-ram area. */
* 0x5c5c5c5c is a memory test pattern. xorl %eax, %eax
* TODO: Check if everything works with the zero pattern as well.
*/
/* xorl %eax, %eax */
xorl $0x5c5c5c5c, %eax
rep stosl rep stosl
#ifdef CARTEST #ifdef CARTEST