soc/intel/cannonlake: Dump ME status info before notify EndOfFirmware
Dumping ME status displays wrong information if we disable Heci1 because it is called after fsp notifies EndOfFirmware and disables Heci1. This patch moves the ME status dump before fsp notify EndOfFirmware. TEST=Boot to OS, check ME dump information Change-Id: Ifd8b18a41c502c4ecfb84698a7669028394589fd Signed-off-by: Bora Guvendik <bora.guvendik@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32991 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Subrata Banik <subrata.banik@intel.com> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
parent
48b2adae1c
commit
9637856b53
|
@ -26,7 +26,6 @@
|
|||
#include <intelblocks/tco.h>
|
||||
#include <reg_script.h>
|
||||
#include <spi-generic.h>
|
||||
#include <soc/me.h>
|
||||
#include <soc/p2sb.h>
|
||||
#include <soc/pci_devs.h>
|
||||
#include <soc/pcr_ids.h>
|
||||
|
@ -95,8 +94,6 @@ static void soc_finalize(void *unused)
|
|||
{
|
||||
printk(BIOS_DEBUG, "Finalizing chipset.\n");
|
||||
|
||||
dump_me_status();
|
||||
|
||||
pch_finalize();
|
||||
|
||||
printk(BIOS_DEBUG, "Finalizing SMM.\n");
|
||||
|
|
|
@ -16,6 +16,6 @@
|
|||
#ifndef _CANNONLAKE_ME_H_
|
||||
#define _CANNONLAKE_ME_H_
|
||||
|
||||
void dump_me_status(void);
|
||||
void dump_me_status(void *unused);
|
||||
|
||||
#endif /* _CANNONLAKE_ME_H_ */
|
||||
|
|
|
@ -235,7 +235,7 @@ fail:
|
|||
}
|
||||
BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_EXIT, print_me_version, NULL);
|
||||
|
||||
void dump_me_status(void)
|
||||
void dump_me_status(void *unused)
|
||||
{
|
||||
union hfsts1 hfsts1;
|
||||
union hfsts2 hfsts2;
|
||||
|
@ -297,3 +297,6 @@ void dump_me_status(void)
|
|||
printk(BIOS_DEBUG, "ME: TXT Support : %s\n",
|
||||
hfsts6.fields.txt_support ? "YES" : "NO");
|
||||
}
|
||||
|
||||
BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_ENTRY, dump_me_status, NULL);
|
||||
BOOT_STATE_INIT_ENTRY(BS_OS_RESUME_CHECK, BS_ON_EXIT, dump_me_status, NULL);
|
||||
|
|
Loading…
Reference in New Issue