GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AGESA,binaryPI: Remove BIST reporting in romstage 

For easier C environment bootblock transition by using
already existing prototypes, BIST will not be passed
to romstage. It is expected that bootblock will have
equivalent code.

Change-Id: I0f8e3657ac79277cd77c397d1b3e931e33a6f5db
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37348
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki 2019-11-29 00:52:01 +02:00
parent dc34a9d6de
commit 9b71804e4f
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/drivers/amd/agesa/romstage.c
View File

@ -16,7 +16,6 @@
#include <arch/romstage.h> #include <arch/romstage.h>
#include <cbmem.h> #include <cbmem.h>
#include <cpu/amd/car.h> #include <cpu/amd/car.h>
#include <cpu/x86/bist.h>
#include <console/console.h> #include <console/console.h>
#include <halt.h> #include <halt.h>
#include <program_loading.h> #include <program_loading.h>
@ -40,7 +39,7 @@ static void fill_sysinfo(struct sysinfo *cb)
agesa_set_interface(cb); agesa_set_interface(cb);
} }
static void bsp_romstage_main(unsigned long bist) static void bsp_romstage_main(void)
{ {
struct postcar_frame pcf; struct postcar_frame pcf;
struct sysinfo romstage_state; struct sysinfo romstage_state;
@ -66,9 +65,6 @@ static void bsp_romstage_main(unsigned long bist)
printk(BIOS_DEBUG, "APIC %02d: CPU Family_Model = %08x\n", printk(BIOS_DEBUG, "APIC %02d: CPU Family_Model = %08x\n",
initial_apic_id, cpuid_eax(1)); initial_apic_id, cpuid_eax(1));
/* Halt if there was a built in self test failure */
report_bist_failure(bist);
agesa_execute_state(cb, AMD_INIT_RESET); agesa_execute_state(cb, AMD_INIT_RESET);
agesa_execute_state(cb, AMD_INIT_EARLY); agesa_execute_state(cb, AMD_INIT_EARLY);
@ -103,7 +99,7 @@ static void bsp_romstage_main(unsigned long bist)
/* We do not return. */ /* We do not return. */
} }
static void __noreturn ap_romstage_main(unsigned long bist) static void __noreturn ap_romstage_main(void)
{ {
struct sysinfo romstage_state; struct sysinfo romstage_state;
struct sysinfo *cb = &romstage_state; struct sysinfo *cb = &romstage_state;
@ -113,9 +109,6 @@ static void __noreturn ap_romstage_main(unsigned long bist)
fill_sysinfo(cb); fill_sysinfo(cb);
/* Halt if there was a built in self test failure */
report_bist_failure(bist);
agesa_execute_state(cb, AMD_INIT_RESET); agesa_execute_state(cb, AMD_INIT_RESET);
agesa_execute_state(cb, AMD_INIT_EARLY); agesa_execute_state(cb, AMD_INIT_EARLY);
@ -127,7 +120,7 @@ static void __noreturn ap_romstage_main(unsigned long bist)
asmlinkage void romstage_main(unsigned long bist) asmlinkage void romstage_main(unsigned long bist)
{ {
if (boot_cpu()) if (boot_cpu())
bsp_romstage_main(bist); bsp_romstage_main();
else else
ap_romstage_main(bist); ap_romstage_main();
} }