GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/siemens/mc_ehl: Remove unneeded 'half_populated' variable 

Since the DRAM population is fixed to both channels on all mc_ehl boards
there is no need to have this 'half_populated' variable at all.
Simply use a fixed 'false' in the call of 'memcfg_init()' and delete
this variable here.

Change-Id: I783c17e6d92322a8b0c094cce803108e718011fa
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58177
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Werner Zeh 2021-10-07 16:22:51 +02:00 committed by Felix Held
parent 59a8355e5f
commit 9cae17d028
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
View File

@ -17,9 +17,6 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
static uint8_t spd_data[0x100]; static uint8_t spd_data[0x100];
const char *cbfs_hwi_name = "hwinfo.hex"; const char *cbfs_hwi_name = "hwinfo.hex";
/* TODO: Read the resistor strap to get number of memory segments */
bool half_populated = false;
/* Initialize SPD information for LPDDR4x from HW-Info primarily with a fallback to /* Initialize SPD information for LPDDR4x from HW-Info primarily with a fallback to
spd.bin in the case where the SPD data in HW-Info is not available or invalid. */ spd.bin in the case where the SPD data in HW-Info is not available or invalid. */
memset(spd_data, 0, sizeof(spd_data)); memset(spd_data, 0, sizeof(spd_data));
@ -35,5 +32,5 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
spd_info.spd_spec.spd_index = 0x00; spd_info.spd_spec.spd_index = 0x00;
} }
/* Initialize variant specific configurations */ /* Initialize variant specific configurations */
memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, half_populated); memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, false);
} }