GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/lynxpoint: Drop typedefs of enum type 

There's no need to use typedefs for enum types. Get rid of it.

Tested with BUILD_TIMELESS=1, Asrock B85M Pro4 remains identical.

Change-Id: I830d95018b33fe6ab7e2c37ebf15bb1df6ceec38
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59620
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Angel Pons 2021-11-24 12:46:12 +01:00 committed by Felix Held
parent 01c9b98ef2
commit 9f043742a8
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/southbridge/intel/lynxpoint/me.c
View File

@ -596,9 +596,9 @@ static int me_icc_set_clock_enables(u32 mask)
} }
/* Determine the path that we should take based on ME status */ /* Determine the path that we should take based on ME status */
static me_bios_path intel_me_path(struct device *dev) static enum me_bios_path intel_me_path(struct device *dev)
{ {
me_bios_path path = ME_DISABLE_BIOS_PATH; enum me_bios_path path = ME_DISABLE_BIOS_PATH;
struct me_hfs hfs; struct me_hfs hfs;
struct me_hfs2 hfs2; struct me_hfs2 hfs2;
@ -879,7 +879,7 @@ mbp_failure:
static void intel_me_init(struct device *dev) static void intel_me_init(struct device *dev)
{ {
struct southbridge_intel_lynxpoint_config *config = dev->chip_info; struct southbridge_intel_lynxpoint_config *config = dev->chip_info;
me_bios_path path = intel_me_path(dev); enum me_bios_path path = intel_me_path(dev);
struct me_bios_payload mbp_data; struct me_bios_payload mbp_data;
/* Do initial setup and determine the BIOS path */ /* Do initial setup and determine the BIOS path */

4
src/southbridge/intel/lynxpoint/me.h
View File

@ -303,14 +303,14 @@ struct me_global_reset {
u8 reset_type; u8 reset_type;
} __packed; } __packed;
typedef enum { enum me_bios_path {
ME_NORMAL_BIOS_PATH, ME_NORMAL_BIOS_PATH,
ME_S3WAKE_BIOS_PATH, ME_S3WAKE_BIOS_PATH,
ME_ERROR_BIOS_PATH, ME_ERROR_BIOS_PATH,
ME_RECOVERY_BIOS_PATH, ME_RECOVERY_BIOS_PATH,
ME_DISABLE_BIOS_PATH, ME_DISABLE_BIOS_PATH,
ME_FIRMWARE_UPDATE_BIOS_PATH, ME_FIRMWARE_UPDATE_BIOS_PATH,
} me_bios_path; };
/* Defined in me_status.c for both romstage and ramstage */ /* Defined in me_status.c for both romstage and ramstage */
void intel_me_status(struct me_hfs *hfs, struct me_hfs2 *hfs2); void intel_me_status(struct me_hfs *hfs, struct me_hfs2 *hfs2);