GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/lint/Kconfig_lint: Update Naked BOOL reference to error 

The lint-stable makefile target only watches for errors in the Kconfig
file, so has not protected additional "Naked" references to BOOL type
Kconfig symbols from entering the tree.  Update it to an error so that
they can't continue coming into the codebase.

Signed-off-by: Martin Roth <martin@coreboot.org>
Change-Id: Icce2a9a627c4fbcaa220df18474cb8bfea8b2a8c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43826
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Martin Roth 2020-07-24 12:42:59 -06:00 committed by Patrick Georgi
parent 552ce003a5
commit a020903307
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/lint/kconfig_lint
View File

@ -332,7 +332,7 @@ sub check_config_macro {
$line = $1 . $3; $line = $1 . $3;
if ( exists $symbols{$symbol} ) { if ( exists $symbols{$symbol} ) {
if ( $symbols{$symbol}{type} eq "bool" ) { if ( $symbols{$symbol}{type} eq "bool" ) {
show_warning( "Naked reference to CONFIG_$symbol used at $file:$lineno." show_error( "Naked reference to CONFIG_$symbol used at $file:$lineno."
. " A 'bool' Kconfig should always be accessed through CONFIG($symbol)." ); . " A 'bool' Kconfig should always be accessed through CONFIG($symbol)." );
} }
} else { } else {