Revert "soc/amd: Add option to select if SOC supports ESPI sub decode"

This reverts commit 64d0ad347b. In the
current revision 3.001 of the PPR #56569 the register exists and the bit
definitions match.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ie7a97843c3dac897f79f229b660b7e30b34eef93
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50824
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>

src/soc/amd/common/block/lpc/Kconfig

@@ -20,7 +20,3 @@ config SOC_AMD_COMMON_BLOCK_USE_ESPI
 	help
 	  Select this option if mainboard uses eSPI instead of LPC (if supported
 	  by platform).
-
-config SOC_AMD_COMMON_BLOCK_HAS_ESPI_SUB_DECODE
-	bool
-	depends on SOC_AMD_COMMON_BLOCK_HAS_ESPI

src/soc/amd/common/block/lpc/espi_util.c

@@ -916,8 +916,7 @@ int espi_setup(void)
 	}
 
 	/* Enable subtractive decode if configured */
-	if (CONFIG(SOC_AMD_COMMON_BLOCK_HAS_ESPI_SUB_DECODE))
-		espi_setup_subtractive_decode(cfg);
+	espi_setup_subtractive_decode(cfg);
 
 	return 0;
 }

src/soc/amd/picasso/Kconfig

@@ -32,7 +32,6 @@ config CPU_SPECIFIC_OPTIONS
 	select SOC_AMD_COMMON_BLOCK_DATA_FABRIC
 	select SOC_AMD_COMMON_BLOCK_GRAPHICS
 	select SOC_AMD_COMMON_BLOCK_HAS_ESPI
-	select SOC_AMD_COMMON_BLOCK_HAS_ESPI_SUB_DECODE
 	select SOC_AMD_COMMON_BLOCK_HDA
 	select SOC_AMD_COMMON_BLOCK_IOMMU
 	select SOC_AMD_COMMON_BLOCK_LPC