GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/autoport: Use romstage.c instead of early_southbridge.c 

Until now, autoport used to create a dummy "romstage.c", then write
romstage code to "early_southbridge.c". While it works, it makes more
sense to write to "romstage.c" instead, as virtually all mainboards do.

Change-Id: If9f9375f9a659e7e685de5f884163813261fa656
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/28851
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2018-10-01 13:14:03 +02:00 committed by Nico Huber
parent 2b59c610d0
commit a5072af67d
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
util/autoport/bd82x6x.go
View File

@ -299,9 +299,8 @@ func (b bd82x6x) Scan(ctx Context, addr PCIDevData) {
File: "southbridge/intel/bd82x6x/acpi/pch.asl", File: "southbridge/intel/bd82x6x/acpi/pch.asl",
}) })
sb := Create(ctx, "early_southbridge.c") sb := Create(ctx, "romstage.c")
defer sb.Close() defer sb.Close()
AddROMStageFile("early_southbridge.c", "")
Add_gpl(sb) Add_gpl(sb)
sb.WriteString(`#include <stdint.h> sb.WriteString(`#include <stdint.h>
#include <string.h> #include <string.h>

4
util/autoport/main.go
View File

@ -827,10 +827,6 @@ func main() {
fmt.Fprintf(bi, "FIXME: put %s\n", missing) fmt.Fprintf(bi, "FIXME: put %s\n", missing)
} }
rs := Create(ctx, "romstage.c")
defer rs.Close()
rs.WriteString("/* dummy file */\n")
if ROMSizeKB == 0 { if ROMSizeKB == 0 {
KconfigBool["BOARD_ROMSIZE_KB_2048"] = true KconfigBool["BOARD_ROMSIZE_KB_2048"] = true
KconfigComment["BOARD_ROMSIZE_KB_2048"] = "FIXME: correct this" KconfigComment["BOARD_ROMSIZE_KB_2048"] = "FIXME: correct this"