GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/acpi: Add _UID for PNP0C02 devices 

When MAINBOARD_HAS_SPEAKER is false, the SPKR gets _HID PNP0C02. This
conflicts with the LDRC device. PNP0C02 is also used other places in the
picasso code base, so I chose a random _UID for each device. The _UIDs
are unique in the code base so it's easy to search for duplicates.

BUG=b:175146875
TEST=Boot trembyle to linux

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I01be41515e011293e90a6b42b8e34de8ec3ffc18
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49813
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Raul E Rangel 2021-01-21 13:59:28 -07:00 committed by Patrick Georgi
parent f38dc8b11d
commit a626d2ed6f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/acpi/lpc.asl
View File

@ -22,6 +22,7 @@ Device(LPCB) {
Device(LDRC) // LPC device: Resource consumption Device(LDRC) // LPC device: Resource consumption
{ {
Name (_HID, EISAID("PNP0C02")) // ID for Motherboard resources Name (_HID, EISAID("PNP0C02")) // ID for Motherboard resources
Name (_UID, 0x3278)
Name (CRS, ResourceTemplate () // Current Motherboard resources Name (CRS, ResourceTemplate () // Current Motherboard resources
{ {
Memory32Fixed(ReadWrite, // Setup for fixed resource location for SPI base address Memory32Fixed(ReadWrite, // Setup for fixed resource location for SPI base address
@ -68,6 +69,7 @@ Device(LPCB) {
Device(SPKR) { /* Speaker */ Device(SPKR) { /* Speaker */
Name(_HID,EISAID(IO61_HID)) Name(_HID,EISAID(IO61_HID))
Name (_UID, 0x7239)
Name(_CRS, ResourceTemplate() { Name(_CRS, ResourceTemplate() {
IO(Decode16, 0x0061, 0x0061, 0, 1) IO(Decode16, 0x0061, 0x0061, 0, 1)
}) })