GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common: Move missing APCB warning to common area 

Move missing APCB warning from birman to amd/common so that other
mainboards can utilize the same warnings if the APCB is missing.

Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com>
Change-Id: I7ae689726ae4f7ccdf6959e47cbb5aee15cdb690
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73002
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Fred Reitberger 2023-02-13 11:06:15 -05:00 committed by Felix Held
parent e814b265ea
commit a63fac3c58
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/amd/birman/Makefile.inc
View File

@ -17,12 +17,6 @@ else
files_added:: warn_no_apcb
endif
PHONY+=warn_no_apcb
warn_no_apcb:
printf "\n\t** WARNING **\n"
printf "coreboot has been built without an APCB.\n"
printf "This image will not boot.\n\n"
ifeq ($(CONFIG_BIRMAN_HAVE_MCHP_FW),y)
$(call add_intermediate, add_mchp_fw)
$(CBFSTOOL) $(obj)/coreboot.pre write -r EC -f $(CONFIG_BIRMAN_MCHP_SIG_FILE) --fill-upward

6
src/soc/amd/common/Makefile.inc
View File

@ -49,4 +49,10 @@ endif # ifneq ($(CONFIG_AMDFW_CONFIG_FILE), )
MAINBOARD_BLOBS_DIR := $(call strip_quotes, $(CONFIG_APCB_BLOBS_DIR))
PHONY+=warn_no_apcb
warn_no_apcb:
printf "\n\t** WARNING **\n"
printf "coreboot has been built without an APCB.\n"
printf "This image will not boot.\n\n"
endif # ifeq ($(CONFIG_SOC_AMD_COMMON),y)