GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/dram: Update RDIMM classification from RIMM to DIMM 

Registered DIMM should be 'FORMFACTOR_DIMM' with 'DETAIL_REGISTERED'
instead of 'FORMFACTOR_RIMM', RIMM has been EOL for so many years.
Memory form factor info is now correct on 4th Gen Xeon server platform
with registered DIMM.

Signed-off-by: Ziang Wang <ziang.wang@intel.com>
Signed-off-by: Kehong Chen <kehong.chen@intel.com>
Change-Id: I1eea4717a2d60c6100c262a2284a2ac5109f114a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75489
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Ziang Wang 2023-05-29 15:53:56 +08:00 committed by Felix Held
parent 23c40997b4
commit a6df40ca43
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/device/dram/spd.c
View File

@ -57,7 +57,7 @@ static void convert_ddr2_module_type_to_spd_info(enum spd_dimm_type_ddr2 module_
switch (module_type) { switch (module_type) {
case SPD_DDR2_DIMM_TYPE_RDIMM: case SPD_DDR2_DIMM_TYPE_RDIMM:
case SPD_DDR2_DIMM_TYPE_MINI_RDIMM: case SPD_DDR2_DIMM_TYPE_MINI_RDIMM:
info->form_factor = MEMORY_FORMFACTOR_RIMM; info->form_factor = MEMORY_FORMFACTOR_DIMM;
info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED;
break; break;
case SPD_DDR2_DIMM_TYPE_UDIMM: case SPD_DDR2_DIMM_TYPE_UDIMM:
@ -85,7 +85,7 @@ static void convert_ddr3_module_type_to_spd_info(enum spd_dimm_type_ddr3 module_
switch (module_type) { switch (module_type) {
case SPD_DDR3_DIMM_TYPE_RDIMM: case SPD_DDR3_DIMM_TYPE_RDIMM:
case SPD_DDR3_DIMM_TYPE_MINI_RDIMM: case SPD_DDR3_DIMM_TYPE_MINI_RDIMM:
info->form_factor = MEMORY_FORMFACTOR_RIMM; info->form_factor = MEMORY_FORMFACTOR_DIMM;
info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED;
break; break;
case SPD_DDR3_DIMM_TYPE_UDIMM: case SPD_DDR3_DIMM_TYPE_UDIMM:
@ -114,7 +114,7 @@ static void convert_ddr4_module_type_to_spd_info(enum ddr4_module_type module_ty
switch (module_type) { switch (module_type) {
case DDR4_SPD_RDIMM: case DDR4_SPD_RDIMM:
case DDR4_SPD_MINI_RDIMM: case DDR4_SPD_MINI_RDIMM:
info->form_factor = MEMORY_FORMFACTOR_RIMM; info->form_factor = MEMORY_FORMFACTOR_DIMM;
info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED;
break; break;
case DDR4_SPD_UDIMM: case DDR4_SPD_UDIMM:
@ -139,7 +139,7 @@ static void convert_ddr5_module_type_to_spd_info(enum ddr5_module_type module_ty
switch (module_type) { switch (module_type) {
case DDR5_SPD_RDIMM: case DDR5_SPD_RDIMM:
case DDR5_SPD_MINI_RDIMM: case DDR5_SPD_MINI_RDIMM:
info->form_factor = MEMORY_FORMFACTOR_RIMM; info->form_factor = MEMORY_FORMFACTOR_DIMM;
info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED;
break; break;
case DDR5_SPD_UDIMM: case DDR5_SPD_UDIMM: