GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfstool: Use endian.h and functions from commonlib 

The endian conversion function be32toh() is defined in
src/include/endian.h, however this file is not used for cbfstool
compilation. Currently the one provided by the host is used and if the
host does not provide this endian.h file, the build will fail.
However, we do have endian conversion functions in commonlib/endian.h
which is available for cbfstool compilation.

Switch from be32toh() to read_be32() in order to avoid relying on a
host provided include file.
We use functions from commonlib/endian.h already in cbfstool.

Change-Id: I106274cf9c69e1849f848920d96a61188f895b36
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/27116
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Werner Zeh 2018-06-15 14:02:18 +02:00
parent aea8eecded
commit a7835c462e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
util/cbfstool/cbfs-mkpayload.c
View File

@ -18,6 +18,7 @@
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <commonlib/endian.h>
#include "elfparsing.h" #include "elfparsing.h"
#include "common.h" #include "common.h"
@ -426,7 +427,7 @@ int parse_fit_to_payload(const struct buffer *input, struct buffer *output,
DEBUG("start: parse_fit_to_payload\n"); DEBUG("start: parse_fit_to_payload\n");
fdt_h = buffer_get(input); fdt_h = buffer_get(input);
if (be32toh(fdt_h->magic) != FDT_HEADER_MAGIC) { if (read_be32(&fdt_h->magic) != FDT_HEADER_MAGIC) {
INFO("Not a FIT payload.\n"); INFO("Not a FIT payload.\n");
return -1; return -1;
} }