GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/romcc: Don't read 'member' if it might be NULL 

The earlier loop exits gracefully iff i == index. In other cases, member
might be NULL, so check that the scan was successful before using its
results.

Change-Id: I818c233d797d82fa819243c4626dd9c4b7de3ac6
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Found-by: Coverity Scan #1129147
Reviewed-on: https://review.coreboot.org/17887
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Patrick Georgi 2016-12-15 15:24:06 +01:00 committed by Patrick Georgi
parent 305035cf27
commit adcad7f046
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
util/romcc/romcc.c
View File

@ -6406,11 +6406,10 @@ static size_t index_reg_offset(struct compile_state *state,
i++; i++;
member = member->right; member = member->right;
} }
size += reg_needed_padding(state, member, size);
if (i != index) { if (i != index) {
internal_error(state, 0, "Missing member index: %u", index); internal_error(state, 0, "Missing member index: %u", index);
} }
size += reg_needed_padding(state, member, size);
} }
else if ((type->type & TYPE_MASK) == TYPE_JOIN) { else if ((type->type & TYPE_MASK) == TYPE_JOIN) {
ulong_t i; ulong_t i;