GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake: Drop `xdci_can_enable()` call 

The `xdci_can_enable()` function is called earlier to configure FSP-S
UPDs. If it returned false, then the xDCI device will be disabled and
the second `xdci_can_enable()` call will never be evaluated.

Change-Id: I4bd08e3194ffccc79c8feaf8f34b2bb4077f760a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55789
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2021-06-23 12:32:59 +02:00 committed by Patrick Georgi
parent 6464c2aa4f
commit adeac8d4f7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/intel/apollolake/xdci.c
View File

@ -40,7 +40,7 @@ static void configure_host_mode_port0(struct device *dev)
* enabled. If it's disabled assume the switch was already done * enabled. If it's disabled assume the switch was already done
* in FSP. * in FSP.
*/ */
if (!dev->enabled || !xdci_can_enable()) if (!dev->enabled)
return; return;
printk(BIOS_INFO, "Putting port 0 into host mode.\n"); printk(BIOS_INFO, "Putting port 0 into host mode.\n");