GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/meteorlake: Remove `FIXME` as SkipMpInit UPD has deprecated 

This patch drops deprecated FSP UPD `SkipMpInit` as Intel MTL FSP
doesn't like to allow an option for boot firmware to perform CPU feature
programming being independent of FSP.

Change-Id: I6447937838ab91551d172936cbb4201ea86a614b
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70557
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
This commit is contained in:
Subrata Banik 2022-12-09 13:19:27 +05:30
parent 95fc5d776a
commit b25aeb5937
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/soc/intel/meteorlake/fsp_params.c
View File

@ -143,11 +143,6 @@ static void fill_fsps_cpu_params(FSP_S_CONFIG *s_cfg,
} else { } else {
/* Use coreboot native driver to perform MP init by default */ /* Use coreboot native driver to perform MP init by default */
s_cfg->CpuMpPpi = (uintptr_t)NULL; s_cfg->CpuMpPpi = (uintptr_t)NULL;
/*
* FIXME: Bring back SkipMpInit UPD in MTL FSP to let coreboot perform
* AP programming independently.
*/
// s_cfg->SkipMpInit = !CONFIG(USE_INTEL_FSP_MP_INIT);
} }
} }