GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp/cpx: Align coreboot CAR symbols to FSP-T 

The CAR set up by FSP-T is at base 0xfe800000 and has a 0x200000 size.
FSP-M seems to have a very large stack usage so it would overflow
other car symbols located below the coreboot stack such as timestamps
and the pre-ram console, which are now fixed.

TEST: boot with ocp/deltalake.

Change-Id: I886f9391ad79fcfa0724109393e3781a08d954b4
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46895
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Christian Walter <christian.walter@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans 2020-10-28 18:24:56 +01:00
parent 3cea0594df
commit b38d6bbe1c
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/soc/intel/xeon_sp/cpx/Kconfig
View File

@ -27,22 +27,25 @@ config PCR_BASE_ADDRESS
config DCACHE_RAM_BASE config DCACHE_RAM_BASE
hex hex
default 0xfe8b0000 default 0xfe800000
config DCACHE_RAM_SIZE config DCACHE_RAM_SIZE
hex hex
default 0x170000 default 0x1fff00
help help
The size of the cache-as-ram region required during bootblock The size of the cache-as-ram region required during bootblock
and/or romstage. and/or romstage. FSP-T reserves the upper 0x100 for
FspReservedBuffer.
config DCACHE_BSP_STACK_SIZE config DCACHE_BSP_STACK_SIZE
hex hex
default 0xA0000 default 0x140000
help help
The amount of anticipated stack usage in CAR by bootblock and The amount of anticipated stack usage in CAR by bootblock and
other stages. It needs to include FSP-M stack requirement and other stages. It needs to include FSP-M stack requirement and
CB romstage stack requirement. CB romstage stack requirement. The integration documentation
says this needs to be 256KiB, but practice show this needs to
be a lot more.
config CPU_MICROCODE_CBFS_LOC config CPU_MICROCODE_CBFS_LOC
hex hex
@ -67,11 +70,13 @@ config STACK_SIZE
config FSP_TEMP_RAM_SIZE config FSP_TEMP_RAM_SIZE
hex hex
depends on FSP_USES_CB_STACK depends on FSP_USES_CB_STACK
default 0xA0000 default 0x40000
help help
The amount of anticipated heap usage in CAR by FSP. The amount of anticipated heap usage in CAR by FSP.
Refer to Platform FSP integration guide document to know Refer to Platform FSP integration guide document to know
the exact FSP requirement for Heap setup. the exact FSP requirement for Heap setup. The FSP integration
documentation says this needs to be at least 128KiB, but practice
show this needs to be 256KiB or more.
config SOC_INTEL_COMMON_BLOCK_P2SB config SOC_INTEL_COMMON_BLOCK_P2SB
def_bool y def_bool y