baytrail: gfx: Don't configure hotplug + backlight registers
- The hotplug register doesn't work in the way we describe. Just leave it at default. - The backlight registers will be configured by the OS driver. BUG=chrome-os-partner:27304 TEST=Manual on Rambi. Boot system in both dev and normal mode, verify that display comes up. Also verify that display functions after warm reboot and suspend / resume. BRANCH=rambi+squawks Change-Id: I5559c131f41c4a14e64e5cec66e18d3a4a46092c Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/193830 Reviewed-by: Aaron Durbin <adurbin@chromium.org> (cherry picked from commit 3f287cc31e41fabef755c37361e2e65ca413c88c) Signed-off-by: Marc Jones <marc.jones@se-eng.com> Reviewed-on: http://review.coreboot.org/7217 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
parent
1d07bf2609
commit
b9590799b3
|
@ -296,9 +296,6 @@ static void gfx_panel_setup(device_t dev)
|
||||||
/* CONTROL */
|
/* CONTROL */
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEA_REG(PP_CONTROL),
|
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEA_REG(PP_CONTROL),
|
||||||
PP_CONTROL_UNLOCK | PP_CONTROL_EDP_FORCE_VDD),
|
PP_CONTROL_UNLOCK | PP_CONTROL_EDP_FORCE_VDD),
|
||||||
/* HOTPLUG */
|
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEA_REG(HOTPLUG_CTRL),
|
|
||||||
0x1 | (config->gpu_pipea_hotplug << 2)),
|
|
||||||
/* POWER ON */
|
/* POWER ON */
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEA_REG(PP_ON_DELAYS),
|
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEA_REG(PP_ON_DELAYS),
|
||||||
(config->gpu_pipea_port_select << 30 |
|
(config->gpu_pipea_port_select << 30 |
|
||||||
|
@ -311,21 +308,12 @@ static void gfx_panel_setup(device_t dev)
|
||||||
/* DIVISOR */
|
/* DIVISOR */
|
||||||
REG_RES_RMW32(PCI_BASE_ADDRESS_0, PIPEA_REG(PP_DIVISOR),
|
REG_RES_RMW32(PCI_BASE_ADDRESS_0, PIPEA_REG(PP_DIVISOR),
|
||||||
~0x1f, config->gpu_pipea_power_cycle_delay),
|
~0x1f, config->gpu_pipea_power_cycle_delay),
|
||||||
/* BACKLIGHT */
|
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEA_REG(BACKLIGHT_CTL),
|
|
||||||
(config->gpu_pipea_backlight_pwm << 16) |
|
|
||||||
(config->gpu_pipea_backlight_pwm >> 1)),
|
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEA_REG(BACKLIGHT_CTL2),
|
|
||||||
BACKLIGHT_ENABLE),
|
|
||||||
REG_SCRIPT_END
|
REG_SCRIPT_END
|
||||||
};
|
};
|
||||||
struct reg_script gfx_pipeb_init[] = {
|
struct reg_script gfx_pipeb_init[] = {
|
||||||
/* CONTROL */
|
/* CONTROL */
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEB_REG(PP_CONTROL),
|
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEB_REG(PP_CONTROL),
|
||||||
PP_CONTROL_UNLOCK | PP_CONTROL_EDP_FORCE_VDD),
|
PP_CONTROL_UNLOCK | PP_CONTROL_EDP_FORCE_VDD),
|
||||||
/* HOTPLUG */
|
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEB_REG(HOTPLUG_CTRL),
|
|
||||||
0x1 | (config->gpu_pipeb_hotplug << 2)),
|
|
||||||
/* POWER ON */
|
/* POWER ON */
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEB_REG(PP_ON_DELAYS),
|
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEB_REG(PP_ON_DELAYS),
|
||||||
(config->gpu_pipeb_port_select << 30 |
|
(config->gpu_pipeb_port_select << 30 |
|
||||||
|
@ -338,12 +326,6 @@ static void gfx_panel_setup(device_t dev)
|
||||||
/* DIVISOR */
|
/* DIVISOR */
|
||||||
REG_RES_RMW32(PCI_BASE_ADDRESS_0, PIPEB_REG(PP_DIVISOR),
|
REG_RES_RMW32(PCI_BASE_ADDRESS_0, PIPEB_REG(PP_DIVISOR),
|
||||||
~0x1f, config->gpu_pipeb_power_cycle_delay),
|
~0x1f, config->gpu_pipeb_power_cycle_delay),
|
||||||
/* BACKLIGHT */
|
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEB_REG(BACKLIGHT_CTL),
|
|
||||||
(config->gpu_pipeb_backlight_pwm << 16) |
|
|
||||||
(config->gpu_pipeb_backlight_pwm >> 1)),
|
|
||||||
REG_RES_WRITE32(PCI_BASE_ADDRESS_0, PIPEB_REG(BACKLIGHT_CTL2),
|
|
||||||
BACKLIGHT_ENABLE),
|
|
||||||
REG_SCRIPT_END
|
REG_SCRIPT_END
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue